RFC-14 Organization of code

[Norbiros]

• Where to put other small crabcraft projects like proxy (TCP proxy #34). I don't think that we should create separate repos for all of them.
  • We can create subproject (in cargo) in main dir.
  • We can create folders like crates, tools to organize our subprojects (like in valence).
• Other projects like minecraft-packets or proxy need to use some code from crabcraft's main codebase (mainly packet bufs). So should we split protocol stuff to separate crate? Or make main crabcraft also library for now?

[goteusz-maszyk]

ok
We can use cargo's WORKSPACES (not subprojects). If it's a built-in, officially supported feature, why not?

[Norbiros]

Workspaces, subprojects, it's the same. I already mentioned them in option 1, but where to put those workspaces? In main dir, in folders like crates, tools?

[goteusz-maszyk]

main dir i think

[Norbiros]

hmmm.... But valence has it nicely organized. And what about second point?

[SzczurekYT]

I'm not a fan of huge monorepos, they feel cluttered for me.
In my opinion if a project is not very closely related to the server, it should go to a separate repo and be a subproject otherwise.
This also has a bonus that the project is more easily discoverable and can have a nice separate readme.

Other projects like minecraft-packets or proxy need to use some code from crabcraft's main codebase (mainly packet bufs). So should we split protocol stuff to separate crate? Or make main crabcraft also library for now?

I think it is going to be the other way - crabcraft will depend on minecraft-packets, not minecraft-packets on crabcraft.
The byte bufs are also included in there, so the proxy can depend on minecraft-packets and that probably should be enough.
If not I think splitting protocol stuff into a separate crate will be the best solution as I don't see any benefit in a proxy depending on the entire server.

Edit: Remove admin abuse @goteusz-maszyk

[Norbiros]

I'm not a fan of huge monorepos, they feel cluttered for me.

Yeah, kinda. Let me give you an example: If I'm working on a proxy in its own repo and I need to change something in minecraft-packets, I have to change all three different repositories, make new versions for all of them, and update all the dependencies. It takes a lot of time.

Also in valence you have like 26 subprojects. So if we had something similar, should we create separate repos for all of them?

In my opinion if a project is not very closely related to the server, it should go to a separate repo and be a subproject otherwise.
This also has a bonus that the project is more easily discoverable and can have a nice separate readme.

In future, yes. But now you need to use proxy to develop crab craft. Proxy is not yet huge project with GUI etc (like pakkit) so I think we can include it in tools for now and in future extract it.

I think it is going to be the other way - crabcraft will depend on minecraft-packets, not minecraft-packets on crabcraft.

Oh, I didn't think about that. We can move protocol bufs to minecraft-packets...

[SzczurekYT]

I agree with what you have said.

[Norbiros]

So monorepos!