Skip to content

Commit cc0b673

Browse files
docs: drop internal references from the streaming importer design
The design doc pointed to internal tracking for the pre-existing namespace lifecycle issues. Say instead that they are not fixed here and that #53, which proposed all-or-nothing creation, is closed for now.
1 parent ecb9431 commit cc0b673

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎docs/STREAMING_DUMP_IMPORT_DESIGN.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Design: memory-bounded streaming SQL dump importer for libsql-server
22

3-
Status: implemented (see `libsql-server/src/namespace/dump_import/`) · Target: `Shopify/libsql`, branch `v0.9.30-shopify-patches` · Related: Retail #35846, LibSQL DB Mover P0
3+
Status: implemented (see `libsql-server/src/namespace/dump_import/`) · Target: `Shopify/libsql`, branch `v0.9.30-shopify-patches`
44

55
Sections marked *as built* record where the implementation refined the original proposal, including the changes made after the adversarial review of PR #51 (§18).
66

@@ -21,7 +21,7 @@ This document is written so that an implementer can follow it step by step witho
2121
## 2. Non-goals
2222

2323
- Enormous single statements / large BLOBs. A per-statement size cap exists purely as a safety valve; dumps exceeding it are rejected, not supported.
24-
- Fixing pre-existing namespace lifecycle issues (metastore row kept after a failed create; directory not cleaned when the request is cancelled). Documented in §13; owned by the DB Mover fence/quarantine work.
24+
- Fixing pre-existing namespace lifecycle issues (metastore row kept after a failed create; directory not cleaned when the request is cancelled). Documented in §13.
2525
- Binary SQLite file ingestion, bottomless memory behavior, Admin request timeouts, export-side changes.
2626
- Changing what the buffered importer does. It is moved, not modified.
2727

@@ -590,7 +590,7 @@ Metrics (`metrics` 0.21 macros with labels):
590590
3. No server-side timeout exists for dump imports; the Admin HTTP request stays open for the whole import. Clients must not time out, or must tolerate (2).
591591
4. Bottomless, if enabled, has its own frame buffering/backpressure outside this design.
592592

593-
These are tracked by the DB Mover quarantine/fence work (Retail #35846/#35848).
593+
None of these is fixed here. #53 proposed all-or-nothing namespace creation, which addresses (1) and (2); it is closed for now, and an operator deletes a namespace left behind by a failed import.
594594

595595
---
596596

0 commit comments

Comments
 (0)