You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit cc0b673
Browse filesBrowse the repository at this point in the historyBrowse files
docs: drop internal references from the streaming importer design
The design doc pointed to internal tracking for the pre-existing
namespace lifecycle issues. Say instead that they are not fixed here
and that #53, which proposed all-or-nothing creation, is closed for now.
Copy file name to clipboardExpand all lines: docs/STREAMING_DUMP_IMPORT_DESIGN.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,6 +1,6 @@
1
1
# Design: memory-bounded streaming SQL dump importer for libsql-server
2
2
3
-
Status: implemented (see `libsql-server/src/namespace/dump_import/`) · Target: `Shopify/libsql`, branch `v0.9.30-shopify-patches` · Related: Retail #35846, LibSQL DB Mover P0
3
+
Status: implemented (see `libsql-server/src/namespace/dump_import/`) · Target: `Shopify/libsql`, branch `v0.9.30-shopify-patches`
4
4
5
5
Sections marked *as built* record where the implementation refined the original proposal, including the changes made after the adversarial review of PR #51 (§18).
6
6
@@ -21,7 +21,7 @@ This document is written so that an implementer can follow it step by step witho
21
21
## 2. Non-goals
22
22
23
23
- Enormous single statements / large BLOBs. A per-statement size cap exists purely as a safety valve; dumps exceeding it are rejected, not supported.
24
-
- Fixing pre-existing namespace lifecycle issues (metastore row kept after a failed create; directory not cleaned when the request is cancelled). Documented in §13; owned by the DB Mover fence/quarantine work.
24
+
- Fixing pre-existing namespace lifecycle issues (metastore row kept after a failed create; directory not cleaned when the request is cancelled). Documented in §13.
- Changing what the buffered importer does. It is moved, not modified.
27
27
@@ -590,7 +590,7 @@ Metrics (`metrics` 0.21 macros with labels):
590
590
3. No server-side timeout exists for dump imports; the Admin HTTP request stays open for the whole import. Clients must not time out, or must tolerate (2).
591
591
4. Bottomless, if enabled, has its own frame buffering/backpressure outside this design.
592
592
593
-
These are tracked by the DB Mover quarantine/fence work (Retail #35846/#35848).
593
+
None of these is fixed here. #53 proposed all-or-nothing namespace creation, which addresses (1) and (2); it is closed for now, and an operator deletes a namespace left behind by a failed import.
0 commit comments