diff --git a/docs/reviews/2026-10-18-resolved-rough-edges.md b/docs/reviews/2026-10-18-resolved-rough-edges.md index 328ef46c..ff8cc1c6 100644 --- a/docs/reviews/2026-10-18-resolved-rough-edges.md +++ b/docs/reviews/2026-10-18-resolved-rough-edges.md @@ -159,3 +159,12 @@ for 38 s, in a run that passed only because no wait was open then. The job now b simulator before `pnpm install`, so that burst lands during the build. In both runs since (39097082261, attempts 1 and 2) it came about 3 minutes after boot, before the paired test started. The paired test then had no stall longer than 2.2 s and took 7–9 min instead of 10–14. + +## iPhone secure-answer field focus in CI, handled 2026-10-30 + +Hosted #453 failed when the Companion UI test typed into a secure answer field that did not yet +have keyboard focus, although a keyboard was visible. #455 (`9f85d61`) makes the test reuse the +existing field-focus wait before typing and keeps the masked-value and exact secret-delivery +assertions. The dedicated iOS 27 simulator passed all 43 native UI and 60 native unit tests; the +original iOS 26.4.1 failure stays preserved. App behaviour is unchanged. +[Evidence](2026-10-30-iphone-secret-focus.md). diff --git a/docs/status.md b/docs/status.md index 57be5545..29479f2a 100644 --- a/docs/status.md +++ b/docs/status.md @@ -62,11 +62,11 @@ and [landing verification](reviews/2026-10-11-landing-clarity.md). ## Review repair delivery -PR #436 repairs two ACP failures after #432 landed: a refused explicit model fails before prompt submission, and failed initialization releases the server so the next turn can start fresh. Scripted-process regressions cover both backend families, and independent review found no blockers in these two repairs. Hosted run 40764795777 at `8db57f5` failed the unchanged 500 ms transcript median gate with a 2019.2 ms median, then reached the macOS job timeout; its desktop suite did not finish and site tests did not run. An exact-candidate local CPU/timeline diagnostic measured a single 234.2 ms cold open but did not reproduce or explain the hosted slowdown and is not five-launch acceptance. The original failure remains unresolved. Integration `78b337d` included main `f03a012`. Fresh build/unit validation passed with 2,244 passes, 26 skips and zero failures; full root E2E passed with 474 desktop cases, seven skips and seven site cases. The five-launch local transcript median was 132.8 ms on Apple M5 Max, 18 cores. These local results do not explain the earlier hosted slowdown; fresh hosted and protected queue validation remain required. The subsequent documentation-only merge of main `33a7820` preserves the same application, test and build tree and reconciles the delivered LM-5 and release rehearsal records. Runtime permission qualification and provider-expansion approval remain separate open gates. +Three review-found repairs landed before v0.4.0 and shipped in it; their evidence stays in their reviews and PRs. -PR #419's LM-5 review found that a rerouted local turn could still be reported completed by the quiet-final timer before interruption was confirmed. The isolated `lm5-reroute-repair` worktree blocks that false success and retains active ownership until native termination. Both event-order regressions failed before the repair. The earlier repair checkpoint passed 53 focused tests and 2,200 unit tests with 25 skips. After the signed delivery rebase, `6ca43ed` passed build, typecheck, full unit validation (2,219 passed, 26 skipped), and root E2E (470 desktop passed, seven skipped; seven site passed). Independent integration review found no blocking findings. PR #424 merged into the #423 delivery branch at `0956376`; its tree exactly matches the reviewed `e0a03ef` candidate. Delivery to `main` landed through PR #423 at `c23e6be`; local-runtime qualification and product admission remain open. The combined branch’s CodeQL alert #28 identified incomplete regex escaping in a test assertion; the repair uses a literal error-message comparison, with five focused tests and the full build/unit command passing (2,219 passed, 26 skipped, zero failures or cancellations). Independent review found no blockers, and hosted CodeQL fixed alert #28. The subsequent macOS run at `d3d61ad` failed the Jev-theme Settings click and teardown (472 passed, four skipped, one failed); its trace is preserved. After integrating main `7a01df2`, including the merged Notes identity repair, final delivery head `618027e` passed protected queue run `40768112164` (473 desktop passes, four skips and seven site passes) and landed through #423. The landed merge tree was verified before its delivery worktree was archived and removed. - -PR #422's CR-6 review found two blockers: unconfirmed child exit was reported as stopped and released ownership, and provider-bound questions were described as staying on the Mac. The isolated `cr6-review-repair` worktree preserves unknown exit ownership and corrects that disclosure. PR #426 has passed independent repair review, build, unit tests (2,196 passed, 23 skipped), typecheck and full root E2E on diagnostic source `4c5eaee` (470 desktop passed, seven skipped; seven site passed). Earlier failures remain recorded, including unexplained Canvas and IPC failures that passed on later runs. PR #426 subsequently passed its protected queue and merged as `d0482a0`; this repair is included in v0.4.0. Native/live acceptance remains separate. +- **ACP refusals and failed initialization** (#436, `469c612`). A refused explicit model fails before prompt submission, and a failed initialization releases the server so the next turn starts fresh. Hosted run 40764795777 failed the 500 ms transcript median gate with a 2019.2 ms median and timed out; the cause was never reproduced locally (234.2 ms cold open, 132.8 ms five-launch median) and stays unexplained. +- **LM-5 reroute repair** (#424 into #423, `c23e6be`). A rerouted local turn can no longer be reported completed by the quiet-final timer before interruption is confirmed. CodeQL alert #28 (regex escaping in a test assertion) was fixed in the same delivery. Local-runtime qualification and product admission remain open. +- **CR-6 exit ownership and disclosure** (#426, `d0482a0`). Unconfirmed child exit keeps ownership instead of reading as stopped, and provider-bound questions are no longer described as staying on the Mac. Native and live acceptance remain separate. ## On main, unreleased @@ -236,23 +236,17 @@ The published application source is `2eda138` (v0.4.0). Later source deliveries Desktop CI memory diagnostics landed through #458 after #456’s cold transcript budget failure. The workflow reuses the existing resource sampler and retains its log as a separate CI artifact; it does not establish the cause of the earlier failure or change the 500 ms gate. The #458 queue passed desktop and site E2E and retained its memory log. See [the diagnostic review](reviews/2026-10-30-desktop-ci-memory.md). -- **CF-7 failed-command follow-up (#280, 2026-10-30).** A separate correction to #450 preserves possible-writer commands even when they exit unsuccessfully: earlier writes are not rolled back by a failure. The new regression first failed on the proposed source; all 39 task-context tests now pass. Full build and unit validation passed (2,252 passed, 26 skipped); full E2E passed (476 desktop, 7 skipped, and 7 site). Independent review found no blocking issues. Protected delivery remains pending. No additional native or human acceptance is claimed. +- **CF-7 failed-command follow-up (#280, 2026-10-30).** A separate correction to #450 preserves possible-writer commands even when they exit unsuccessfully: earlier writes are not rolled back by a failure. The new regression first failed on the proposed source; all 39 task-context tests now pass. Full build and unit validation passed (2,252 passed, 26 skipped); full E2E passed (476 desktop, 7 skipped, and 7 site). Independent review found no blocking issues. It landed through #453 (`f51ef7e`) and is in the v0.4.1 candidate. No additional native or human acceptance is claimed. - **LM-5 auxiliary dispatch regressions.** Candidate tests exercise deterministic local approvals, human approval fallback and four local failure outcomes with a recording Jev transport and cloud positive control. Thirteen focused cases passed; removing the local approval guard made both local approval cases fail on unexpected dispatch. Build and full unit validation passed (2,251 passes, 26 skips); independent review found no actionable findings. Protected delivery landed through #447; native offline acceptance and the remaining #380 criteria stay open. [Evidence](reviews/2026-10-30-lm5-auxiliary-dispatch.md). -- **Canvas Escape harness readiness.** Repeated hosted failures showed the main pane still hidden after guest Escape. A controlled delayed-IPC diagnostic proved that renderer full-view state can precede native readiness. The test-only candidate waits for the native guest to become visible at the expanded preview bounds before sending one Escape, retaining all security and lifecycle assertions. Five candidate repetitions and full local validation passed; the implementation also passed hosted macOS validation. The Windows first failure, passing retry and original CodeQL upload failure remain recorded. Protected delivery remains pending. [Evidence](reviews/2026-10-30-canvas-native-readiness.md). - -- **Markdown keyboard E2E sequencing repair.** A native scroll completion race reproduced in a blank Electron window. The proposed test waits for the rightward scroll to finish before reversing, preserving the original movement and accessibility assertions. Fresh build and unit validation passed (2,196 passed, 23 skipped), the focused E2E passed 15/15 across three themes, and independent review found no blockers. Protected delivery landed through #435 and is included in v0.4.0. [Evidence](reviews/2026-10-28-markdown-scroll-sequencing.md). - -- **Code Review packaged-app harness repair.** The shared harness and standalone IPC test now honor `MODEX_PACKAGED_APP`, including crash recovery. Two executable-identity regressions failed before the repair and passed afterward against a local ad-hoc bundle; development checks also passed. This is scoped harness evidence, not signed-release or human acceptance. [Evidence and remaining coverage limits](reviews/2026-10-28-code-review-packaged-harness.md). +- **Canvas Escape harness readiness.** Repeated hosted failures showed the main pane still hidden after guest Escape. A controlled delayed-IPC diagnostic proved that renderer full-view state can precede native readiness. The test-only candidate waits for the native guest to become visible at the expanded preview bounds before sending one Escape, retaining all security and lifecycle assertions. Five candidate repetitions and full local validation passed; the implementation also passed hosted macOS validation. The Windows first failure, passing retry and original CodeQL upload failure remain recorded. It landed through #446 (`2ce777c`) on 2026-10-30, after v0.4.0. [Evidence](reviews/2026-10-30-canvas-native-readiness.md). -- **Notes history identity repair.** Repeated history toggles could duplicate revision rows or leave history visible after closing because the history and editor siblings shared a React key. The isolated `notes-history-identity` repair gives them distinct identities; three regression repetitions failed before the fix and passed afterward. Independent review found no blockers. Build and full unit/E2E checks passed (2,191 unit passed, 23 skipped; 470 desktop passed, seven skipped; seven site passed). Protected delivery landed in #429 (`7a01df2`); its successful merge-queue run passed 473 desktop tests with four skips and seven site tests. See [repair evidence](reviews/2026-10-28-notes-history-identity.md). +- **Notes history identity repair.** History toggles could duplicate revision rows because the history and editor siblings shared a React key; the repair landed through #429 (`7a01df2`) and shipped in v0.4.0. [Repair evidence](reviews/2026-10-28-notes-history-identity.md). -- **LM-5 effective subagent admission.** A reproduced policy gap accepted enabled native subagent flags despite disabled launch settings. The repair requires both effective values to be false; ten regressions failed before the fix, and 26 focused policy/execution tests now pass, including refusal before a native thread opens. A configuration-only CLI 0.166.0 probe confirms the explicit false report shape. Build and full unit validation passed (2,254 passes, 26 skips); independent review found no blocking findings. Protected delivery remains pending; native qualification stays separate. [Evidence](reviews/2026-10-30-lm5-subagent-policy.md). +- **LM-5 effective subagent admission.** A reproduced policy gap accepted enabled native subagent flags despite disabled launch settings. The repair requires both effective values to be false; ten regressions failed before the fix, and 26 focused policy/execution tests now pass, including refusal before a native thread opens. A configuration-only CLI 0.166.0 probe confirms the explicit false report shape. Build and full unit validation passed (2,254 passes, 26 skips); independent review found no blocking findings. It landed through #448 (`ba8f289`) on 2026-10-30, after v0.4.0, and is in the v0.4.1 candidate; native qualification stays separate. [Evidence](reviews/2026-10-30-lm5-subagent-policy.md). -- **LM-2 credential repair, included in v0.4.0.** PR #418 delivered the credential-copy and stale-discovery fixes from closed #401, together with isolation that prevents fake child PIDs from reaching OS signals, at `6c9000f`. Build, full unit tests, typechecks and the Electron IPC journey are recorded in the [reconciliation evidence](reviews/2026-10-26-lm2-credential-repair.md). This source delivery is separate from local-runtime qualification and product admission. - -- **v0.4.0 post-publication acceptance and Companion 0.4.0 (9).** Desktop publication is complete. The v0.3.0-to-v0.4.0 background upgrade remains unverified: the installed Mac already reports signed 0.4.0 and was left unchanged. Companion build 9 has not been delivered by this release session; its TestFlight upload and physical-device checks remain separate. Human accessibility, real-provider and native-platform account/session checks retain their existing gates. [Publication evidence and limits](reviews/2026-10-24-v0.4.0-release-review.md#published--2026-10-30-utc). +- **v0.4.0 post-publication acceptance and Companion 0.4.0 (9).** Desktop publication is complete. v0.3.0's two post-publication gates (the banner upgrade of the release Mac and the Companion 0.3.0 (8) upload) are superseded: the installed Mac reports signed 0.4.0, and Companion build 9 replaces build 8. The v0.3.0-to-v0.4.0 background upgrade remains unverified: the installed Mac already reports signed 0.4.0 and was left unchanged. Companion build 9 has not been delivered by this release session; its TestFlight upload and physical-device checks remain separate. Human accessibility, real-provider and native-platform account/session checks retain their existing gates. [Publication evidence and limits](reviews/2026-10-24-v0.4.0-release-review.md#published--2026-10-30-utc). - **Local execution through Codex, in main only and not yet admitted** (LM-3 [#379](https://github.com/TypeSafeAI/modex/issues/379), [PR #423](https://github.com/TypeSafeAI/modex/pull/423), branch `lm3-signed-delivery`). A thread with a `localTarget` runs on its own `codex app-server` child: a private @@ -281,20 +275,13 @@ Desktop CI memory diagnostics landed through #458 after #456’s cold transcript - **Companion network acceptance (#109).** The [two-LAN evidence map](reviews/2026-10-28-companion-two-lan-acceptance.md) ties each of the four #109 requirements to the tests that prove it, adds the last race (the interface list changes while Forget paired phones or Turn off runs, and no listener survives with the old token; both shown red against a mutation, green on `main`), and holds the physical two-subnet procedure. Two gates remain with Val: running that procedure, and deciding whether VPN tunnels and virtual bridges with private addresses get a listener ([question](https://github.com/TypeSafeAI/modex/issues/109#issuecomment-6464762470)). The filter is unchanged until Val answers. -- **Integrated review candidate.** CF-4 keyboard/performance, CR-5 remote diffs, CR-8 acceptance checks and the unwired CR-7 intent foundation are reconciled on signed candidate `e25a554`. Full build, unit and typecheck passed; full E2E passed 450 desktop cases with seven skips and seven site cases. [The integration receipt](reviews/2026-10-24-integrated-review.md) preserves the first failures, their repairs, source ancestry and remaining human, policy and provider gates. Hosted validation and protected delivery are recorded separately. CF-8's missing-artifact matrix row now records the existing #328 unit evidence, reconfirmed in the CR-7 integration repair's full unit run; live and human acceptance remain separate. +- **Integrated review candidate `e25a554`.** CF-4 keyboard/performance, CR-5 remote diffs, CR-8 acceptance checks and the unwired CR-7 intent foundation were reconciled on this signed candidate, which landed through #404 (`e3527f4`) and shipped in v0.4.0. [The integration receipt](reviews/2026-10-24-integrated-review.md) preserves the first failures, their repairs, source ancestry and the remaining human, policy and provider gates. - **Revision-bound remote diffs** (CR-5 [#324](https://github.com/TypeSafeAI/modex/issues/324), [PR #395](https://github.com/TypeSafeAI/modex/pull/395)). The integration repair distinguishes the proven three-dot diff base from the target tip in file pages, context, anchors and labels. Four failing-first regressions and a real GitHub read confirmed the defect and correction; full build, unit, typecheck and E2E checks passed (430 desktop passes, seven skips, seven site passes). The original candidate's resource bounds remain in place. Original R4 comparison, human acceptance and the Viewed decision remain open. [Repair evidence](reviews/2026-10-24-cr5-merge-base.md); [original candidate evidence](reviews/2026-10-23-cr5-remote-diffs.md). - **LM-1 local-model contract and native feasibility (#377 / #376).** Val accepted narrow Gate A on 2026-10-24 for the producer at main `bb0e1a4`, including the shared identity/runtime mapping from #400, and the recorded Codex 0.163.0/0.164.0 + Strata 0.1.47 tool/Stop/continuation evidence. The loopback metadata boundary is separately approved; no local execution feature is enabled. LM-2 consumes it through #403. Val explicitly deferred the additional Ollama/LM Studio app-server probe until a local coding model exists: Ollama has no models, and this Mac has only an LM Studio embedding model; linked-device LLMs are outside scope. [Contract/source map](local-models.md), [native feasibility](reviews/2026-10-22-lm1-feasibility.md) and [acceptance/availability](reviews/2026-10-24-lm1-acceptance.md). -- **CF-4 Markdown closeout (#277).** The `cf4-closeout` candidate (named keyboard stops for table/code overflow, reference-viewport captures, the approved 500 ms median cold-open gate, and Markdown rows C1–C5 in the shared #281 human checklist) landed on `main` through #404 (`e3527f4`, 2026-10-24); #371 was closed as superseded. [The closeout evidence](reviews/2026-10-22-cf4-closeout/checkpoint.md) keeps the local, hosted and integrated measurements apart and records the human review candidate prepared on 2026-10-28: `main` at `b643617`, built and seeded in `.worktrees/cf4-voiceover`, with the focused rendering, keyboard and five-launch budget checks 11/11 and a 170 ms median; the record merged through #427 (`8ab2072`), whose hosted CI failed once on an unrelated #422 agent case and passed on rerun with a 322.9 ms median, both kept in the evidence. On 2026-10-30 Val deferred C1–C5 in writing; no row was run or passed, and the rows stay in the shared checklist for a later build. #277 closed with that deferral, recorded in the checkpoint. The former `cf4-voiceover` worktree has since been removed; its verified Git bundle preserves committed source, while the ignored seeded home and built app require separate recovery or rebuilding and reseeding. A first-pass full suite on `main` at `907ba08` then passed locally (2,244 unit passes, 26 skips; 475 desktop and 7 site E2E passes, 7 skips; five-launch median 239.0 ms). - -- **v0.3.0 after publication.** v0.3.0 was published on 2026-10-20 from the signed tag on - `30ee279`. Two release gates need Val at the Mac: upgrading the release Mac from v0.2.0 through - its own update banner, and uploading Companion 0.3.0 (8) to TestFlight. Build 8 is cut from the - same tag, so it also carries thread archiving from the phone, which Companion 0.2.0 (7) was cut - for. v0.2.0's gates, its banner upgrade from v0.1.0 and the build 7 upload, are superseded: - v0.1.0 is now offered v0.3.0. [Review](reviews/2026-10-20-v0.3.0-release-review.md). +- **CF-4 Markdown closeout (#277), closed 2026-10-30.** The `cf4-closeout` candidate (named keyboard stops for table/code overflow, reference-viewport captures, the approved 500 ms median cold-open gate, and Markdown rows C1–C5 in the shared #281 human checklist) landed through #404 (`e3527f4`) and shipped in v0.4.0; the human review candidate record landed through #427. On 2026-10-30 Val deferred rows C1–C5 in writing; no row was run or passed, the rows stay in the shared checklist for a later build, and #277 closed with that deferral (#444, #449). A first-pass full suite on `main` at `907ba08` passed locally (#454). The former `cf4-voiceover` worktree was removed; its Git bundle preserves committed source, and the seeded home and built app need rebuilding and reseeding. [Closeout evidence](reviews/2026-10-22-cf4-closeout/checkpoint.md). - **Native conversation fidelity** ([tracker #273](https://github.com/TypeSafeAI/modex/issues/273)). The slices that landed through #335 and #333 shipped in v0.3.0; the @@ -324,7 +311,7 @@ Desktop CI memory diagnostics landed through #458 after #456’s cold transcript The [CR-8 journey refresh](reviews/2026-10-28-cr8-journey-refresh.md) adds R2 activity scrolling and R3 instructions focus/Escape coverage to the existing production-read fixture journey, with captures and no provider starts or external writes. Focused validation and the full local suite passed (474 desktop, seven skipped, seven site); PR #440 and its merge queue passed hosted validation (477 desktop, four skipped, seven site), and the change is on main. Original-reference, human and live-provider/write acceptance remain open. - The [integrated CR-8 review-flow fixture](reviews/2026-10-28-cr8-review-flow.md) connects a populated remote diff, synthetic native review, anchored draft, explicit submission and restart reconciliation, requiring exactly one provider run and one synthetic write. The extended fixture passed build/unit validation and full E2E (475 desktop passes, 7 skips and 7 site passes). All seven combined agent and journey tests passed after integrating #440; hosted validation remains pending. Human, original-reference and live-service acceptance remain open. + The [integrated CR-8 review-flow fixture](reviews/2026-10-28-cr8-review-flow.md) connects a populated remote diff, synthetic native review, anchored draft, explicit submission and restart reconciliation, requiring exactly one provider run and one synthetic write. The extended fixture passed build/unit validation and full E2E (475 desktop passes, 7 skips and 7 site passes). All seven combined agent and journey tests passed after integrating #440; it landed through #441 (`eca2bd9`) and is in v0.4.0. Human, original-reference and live-service acceptance remain open. - **Mac App Store edition.** A sandboxed Store front end with a separately installed signed host, as Val chose. [Investigation and parity matrix](mac-app-store.md). @@ -414,8 +401,6 @@ Desktop CI memory diagnostics landed through #458 after #456’s cold transcript ## Known rough edges -- **iPhone secure-answer focus readiness.** Hosted #453 failed when typing into a secure field that did not have keyboard focus, despite a keyboard being visible. A separate test-harness candidate reuses the existing field-focus wait while retaining masked-value and exact secret-delivery assertions. The dedicated iOS 27 simulator passed all 43 native UI and 60 native unit tests, and independent review found no actionable findings. Repository build/unit validation passed (2,268 passed, 26 skipped); protected delivery remains pending and the original iOS 26.4.1 failure stays preserved. [Evidence](reviews/2026-10-30-iphone-secret-focus.md). - Fixed ones move to [resolved rough edges](reviews/2026-10-18-resolved-rough-edges.md), with the PR that fixed each. @@ -468,7 +453,7 @@ that fixed each. Roughly in the order they earn their place; none is scheduled. -1. **Windows and Linux acceptance.** Their installers shipped with v0.1.0. Provider-account acceptance, KWallet6 and full graphical sessions, and historical schema migration remain unproven; see [native-platforms.md](native-platforms.md). A candidate pins the KWallet5 acceptance harness to its qualified Ubuntu 24.04 baseline after the moving runner label selected Ubuntu 26/KWallet6 without the expected daemon. Existing assertions remain required; local build/unit passed (2,268 passed, 26 skipped), and independent review found no actionable findings. Hosted Linux validation and protected delivery remain pending. [Evidence](reviews/2026-10-30-linux-wallet-baseline.md). +1. **Windows and Linux acceptance.** Their installers shipped with v0.1.0. Provider-account acceptance, KWallet6 and full graphical sessions, and historical schema migration remain unproven; see [native-platforms.md](native-platforms.md). The KWallet5 acceptance harness is pinned to its qualified Ubuntu 24.04 baseline (#456, `727e022`) after the moving runner label selected Ubuntu 26/KWallet6 without the expected daemon; Ubuntu 26/KWallet6 stays unverified. [Evidence](reviews/2026-10-30-linux-wallet-baseline.md). 2. **Routines that change code** (Routines Phase 2). Read-only routines shipped in v0.2.0. Agent-mode routines in a claimed worktree wait for the approval gate decision. See the [routines specification](specs/2026-10-11-modex-routines-spec.md). diff --git a/docs/superpowers/plans/2026-10-20-cf7-context-map.md b/docs/superpowers/plans/2026-10-20-cf7-context-map.md index fe4e709e..82977a05 100644 --- a/docs/superpowers/plans/2026-10-20-cf7-context-map.md +++ b/docs/superpowers/plans/2026-10-20-cf7-context-map.md @@ -1,5 +1,7 @@ # CF-7 context map implementation plan +**Status (2026-10-30): delivered.** The files list landed in #355 (`3e416ab`) and shipped in v0.4.0; the close-out follow-ups #450 and #453 name commands that may have changed unlisted files. The boxes below were not ticked during execution and are historical. Behaviour: [task-context.md](../../task-context.md#context-map). + > **For agentic workers:** this plan is executed inline in the #273 tracker session (TDD, red first). > Steps use checkbox (`- [ ]`) syntax for tracking. diff --git a/docs/superpowers/plans/2026-10-23-cr4-overview.md b/docs/superpowers/plans/2026-10-23-cr4-overview.md index 066a5474..d62f957b 100644 --- a/docs/superpowers/plans/2026-10-23-cr4-overview.md +++ b/docs/superpowers/plans/2026-10-23-cr4-overview.md @@ -1,5 +1,7 @@ # CR-4 overview implementation +**Status (2026-10-30): delivered** in #393 (`6c40547`), integrated through #404 and shipped in v0.4.0. Evidence: [CR-4 review](../../reviews/2026-10-23-cr4-overview.md). Original-reference comparison and human accessibility remain open on #323. + Implement the accepted #320/#323 design in the existing Code Review host. Use its account-scoped Reader, read models, Markdown renderer, tokens and unavailable capabilities. No GitHub writes or foreign-code execution. 1. Add red model tests for stable, deterministic activity pagination, failed-page completeness, strict external preview destinations and ambiguous/cyclic stack data. Implement pure presentation helpers. diff --git a/docs/superpowers/plans/2026-10-23-cr5-integration.md b/docs/superpowers/plans/2026-10-23-cr5-integration.md index dcc3d096..8a83d5c7 100644 --- a/docs/superpowers/plans/2026-10-23-cr5-integration.md +++ b/docs/superpowers/plans/2026-10-23-cr5-integration.md @@ -1,5 +1,7 @@ # CR-5 integration and delivery plan +**Status (2026-10-30): delivered.** The integrated CR-5 remote diffs landed through #404 (`e3527f4`) and shipped in v0.4.0; the merge-base repair is in [cr5-merge-base](../../reviews/2026-10-24-cr5-merge-base.md). Original R4 comparison, human acceptance and the Viewed decision remain open on #324. + **Goal:** Deliver the specified CR-5 remote diff behavior in a signed, review-ready PR, coordinated with #393, without merging or releasing. **Spec:** #324 and the user's explicit CR-5 goal; `docs/design/code-review.md`, controls C63–C79. The existing CR-5 implementation and its evidence are input artifacts, not fresh acceptance proof. diff --git a/docs/superpowers/plans/2026-10-23-cr5-remote-diffs.md b/docs/superpowers/plans/2026-10-23-cr5-remote-diffs.md index 071b177a..155771b7 100644 --- a/docs/superpowers/plans/2026-10-23-cr5-remote-diffs.md +++ b/docs/superpowers/plans/2026-10-23-cr5-remote-diffs.md @@ -1,5 +1,7 @@ # CR-5 remote diffs implementation plan +**Status (2026-10-30): superseded** by [2026-10-23-cr5-integration.md](2026-10-23-cr5-integration.md), which integrated this plan's candidate commits and landed through #404 (`e3527f4`). The boxes below were not ticked during execution and are historical. + **Goal:** Complete #324 against the existing CR-1/2/3 read contracts, ending with a signed reviewable PR without merging. **Architecture:** Keep a pure bounded patch and anchor model beside the remote view. Use the existing Reader for every remote read and cancellation. Reuse pure Changes presentation only; no local filesystem or mutation handler enters the remote view. diff --git a/docs/superpowers/plans/2026-10-23-cr6-isolation.md b/docs/superpowers/plans/2026-10-23-cr6-isolation.md index a143ffe6..6fde9c54 100644 --- a/docs/superpowers/plans/2026-10-23-cr6-isolation.md +++ b/docs/superpowers/plans/2026-10-23-cr6-isolation.md @@ -1,5 +1,7 @@ # CR-6 Phase 1 isolation proof +**Status (2026-10-30): delivered** in #396 (`03ce71a`); Phase 2 followed in #422 (`b643617`) and the exit-ownership repair #426, all shipped in v0.4.0. Evidence: [isolation](../../reviews/2026-10-23-cr6-isolation.md), [native review](../../reviews/2026-10-28-cr6-native-review.md). An authenticated live run and C82 remain open on #325. + Investigate installed native CLI controls without enabling review or starting inference. Keep CR-6 capability gates unchanged, preserve C82, and leave Phase 2 gated on #393/#395 landing. 1. Inspect current contracts, backend launches, approvals and journal semantics. Record installed versions and current official controls, separating documentation from observed enforcement. diff --git a/docs/superpowers/plans/2026-10-23-cr7-intents.md b/docs/superpowers/plans/2026-10-23-cr7-intents.md index fd8773b4..669c334d 100644 --- a/docs/superpowers/plans/2026-10-23-cr7-intents.md +++ b/docs/superpowers/plans/2026-10-23-cr7-intents.md @@ -1,5 +1,7 @@ # CR-7 draft and intent foundation implementation plan +**Status (2026-10-30): delivered.** The foundation landed through #404 (`e3527f4`), the anchor binding in #410 (`deb373a`) and the write increments and repair in #416 (`b3aad0d`), all shipped in v0.4.0. Evidence: [intents](../../reviews/2026-10-23-cr7-intents.md), [write repair](../../reviews/2026-10-26-cr7-write-repair.md). The live write waits for a disposable repository Val names (#326). + > **For agentic workers:** Use superpowers:executing-plans to implement this user-specified increment inline, with a fresh independent whole-branch review. **Goal:** Deliver only the preparatory local draft and intent foundation requested in the attached CR-7 goal.