From 00d177cd218e2e670cb8b07728c9cef12c96f49f Mon Sep 17 00:00:00 2001 From: sc57 Date: Wed, 30 Sep 2026 20:22:33 +0800 Subject: [PATCH] =?UTF-8?q?test(desktop):=20=E4=BF=AE=E5=A4=8D=E4=B8=A4?= =?UTF-8?q?=E4=B8=AA=E6=A1=8C=E9=9D=A2=E7=AB=AF=E6=B5=8B=E8=AF=95=E7=9A=84?= =?UTF-8?q?=E5=B4=A9=E6=BA=83=E4=B8=8E=E6=94=B6=E5=B0=BE=E5=BC=82=E5=B8=B8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - test_discard_unsaved_edit_reopens_from_formally_saved_subtitle: 构造第二个窗口时用 patch.object 替换 DesktopWindow 类属性 _start_waveform, 在已有窗口存活时会让 PySide 在 _appbar 设置图标处 access violation,用例稳定崩溃; 且该 patch 只在构造期间生效,拦不到异步载入后才发生的调用。 改为构造后在实例上替换,并由 addCleanup 覆盖整个用例。 - test_explicit_seek_ignores_stale_player_position_and_playing_highlight: FakePlayer 缺少 close(),收尾关窗时 closeEvent 调用 player.close() 抛出 AttributeError, 后续 Qt 事件再进入 Python 重写时处于异常状态;补一个空的 close()。 Co-Authored-By: Claude Opus 5.5 --- tests/unit/test_desktop_render.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/unit/test_desktop_render.py b/tests/unit/test_desktop_render.py index 17f6a70..5fbfd1f 100644 --- a/tests/unit/test_desktop_render.py +++ b/tests/unit/test_desktop_render.py @@ -164,9 +164,13 @@ def test_discard_unsaved_edit_reopens_from_formally_saved_subtitle(self): from autoslice.desktop.qt_app.window import DesktopWindow with patch("autoslice.desktop.qt_app.window.MpvAdapter", - side_effect=OSError("测试无播放器")), \ - patch.object(DesktopWindow, "_start_waveform"): + side_effect=OSError("测试无播放器")): reopened = DesktopWindow(SubmissionProjectService(self.root), self.storage) + # _start_waveform 在异步载入完成后才调用,须在实例上替换并覆盖整个用例; + # 构造期间 patch 类属性既拦不到这次调用,还会让 PySide 在构造第二个窗口时崩溃。 + waveform = patch.object(reopened, "_start_waveform") + waveform.start() + self.addCleanup(waveform.stop) reopened.show() def close_reopened(): @@ -322,6 +326,10 @@ def __init__(self): def seek(self, position, pause=True): self.seeks.append((position, pause)) + def close(self): + # 用例收尾关窗时 closeEvent 会调用 player.close() + pass + self.window.player = FakePlayer() self.window._media_ready = True self.window._player_duration = 20.0