`batches_to_flight_data()` should not require ownership of arguments

[avantgardnerio]

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The signature is:

pub fn batches_to_flight_data(
    schema: Schema,
    batches: Vec<RecordBatch>,
) -> Result<Vec<FlightData>, ArrowError> {

Which means if a caller can't give up ownership (needs to re-use for something else), they need to clone these expensive objects.

Describe the solution you'd like

Accept a reference instead.

Describe alternatives you've considered

Clone away.

Additional context

[avantgardnerio]

@alamb @tustvold thoughts?

[alamb]

I like the idea of "From" impls and a bunch of doc comment examples

[Rich-T-kid]

take

[Rich-T-kid]

I implemented this in #11010

Which means if a caller can't give up ownership (needs to re-use for something else), they need to clone these expensive objects.

record batches arent that expensive to clone since they are mostly a collection of arc pointers. I do agree callers should own the backing storage of the record batches