From 5b4fdf368686a3ce0c41e60e40c533f0139d94d5 Mon Sep 17 00:00:00 2001 From: Jack Chuma Date: Fri, 6 Nov 2026 22:57:16 -0500 Subject: [PATCH 1/2] test(task-catalog): drop listTasks tests that repeat other tests Co-authored-by: Toshi J-Engine-Session: je:e00141da-8385-4cd2-899f-04a870173b17 --- src/lib/__tests__/task-catalog.test.ts | 57 +------------------------- 1 file changed, 2 insertions(+), 55 deletions(-) diff --git a/src/lib/__tests__/task-catalog.test.ts b/src/lib/__tests__/task-catalog.test.ts index 16d2695..f856e9c 100644 --- a/src/lib/__tests__/task-catalog.test.ts +++ b/src/lib/__tests__/task-catalog.test.ts @@ -296,8 +296,8 @@ describe('listTasks', () => { }, ]); await fs.unlink(path.join(taskDir, 'README.md')); - expect(catalog.listTasks(NetworkType.Mainnet)).toEqual([ - { ...base, name: 'EVM title', description: 'EVM description.', status: undefined }, + expect(JSON.parse(JSON.stringify(catalog.listTasks(NetworkType.Mainnet)))).toEqual([ + { ...base, name: 'EVM title', description: 'EVM description.' }, ]); }); @@ -309,35 +309,6 @@ describe('listTasks', () => { } } - it('discovers active task folders without root-level network folders', async () => { - await makeTask( - '2025-06-04-upgrade-foo', - 'mainnet', - [ - '# Upgrade Foo', - '', - 'Status: READY TO SIGN', - '', - '## Description', - '', - 'Example upgrade task.', - ].join('\n') - ); - - const upgrades = createTaskCatalog(tempDir).listTasks(NetworkType.Mainnet); - - expect(upgrades).toEqual([ - expect.objectContaining({ - id: '2025-06-04-upgrade-foo', - name: 'Upgrade Foo', - date: '2025-06-04', - network: NetworkType.Mainnet, - status: TaskStatus.ReadyToSign, - description: 'Example upgrade task.', - }), - ]); - }); - it('returns pending status for a task with a pending README status', async () => { await makeTask('2025-06-04-upgrade-foo', 'mainnet', 'Status: PENDING'); @@ -346,30 +317,6 @@ describe('listTasks', () => { expect(upgrades).toEqual([expect.objectContaining({ status: TaskStatus.Pending })]); }); - it('returns executed status for a task with an executed README status', async () => { - await makeTask('2025-06-04-upgrade-foo', 'mainnet', 'Status: EXECUTED'); - - const upgrades = createTaskCatalog(tempDir).listTasks(NetworkType.Mainnet); - - expect(upgrades).toEqual([expect.objectContaining({ status: TaskStatus.Executed })]); - }); - - it('omits status when the README has no status line', async () => { - await makeTask('2025-06-04-upgrade-foo', 'mainnet', '# Upgrade Foo'); - - const upgrades = createTaskCatalog(tempDir).listTasks(NetworkType.Mainnet); - - expect(JSON.parse(JSON.stringify(upgrades))).toEqual([ - { - id: '2025-06-04-upgrade-foo', - name: 'Upgrade Foo', - description: 'Smart contract upgrade deployment', - date: '2025-06-04', - network: NetworkType.Mainnet, - }, - ]); - }); - it('uses the default description when the README has no descriptive text', async () => { await makeTask('2025-06-04-upgrade-foo', 'mainnet', '# Upgrade Foo\n\nStatus: PENDING'); From 5b303e0f4dce6126a6c6892d0d12a0d68d0b34db Mon Sep 17 00:00:00 2001 From: Jack Chuma Date: Fri, 6 Nov 2026 23:04:27 -0500 Subject: [PATCH 2/2] fix: address review round 1 findings Co-authored-by: Toshi J-Engine-Session: je:e00141da-8385-4cd2-899f-04a870173b17 --- src/lib/__tests__/task-catalog.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/__tests__/task-catalog.test.ts b/src/lib/__tests__/task-catalog.test.ts index f856e9c..727bd6a 100644 --- a/src/lib/__tests__/task-catalog.test.ts +++ b/src/lib/__tests__/task-catalog.test.ts @@ -274,7 +274,7 @@ describe('listTasks', () => { await fs.writeFile(path.join(evmDir, 'README.md'), '# EVM title\n\nEVM description.'); await fs.writeFile( networkReadme, - '# Network title\r\n\r\nStatus: READY TO SIGN\r\n\r\n## Description\r\nNetwork description.\r\n\r\n## Other\r\nIgnored.' + '# Network title\r\n\r\nStatus: READY TO SIGN\r\n\r\n## Description\r\n\r\nNetwork description.\r\n\r\n## Other\r\nIgnored.' ); const catalog = createTaskCatalog(tempDir); const base = { id, date: '2025-06-04', network: NetworkType.Mainnet };