From c3c79edd236308176603e22bd0c6e89e2d228363 Mon Sep 17 00:00:00 2001
From: lforst <8118419+lforst@users.noreply.github.com>
Date: Wed, 23 Sep 2026 20:33:30 +0000
Subject: [PATCH 1/2] ref!: Simplify Eval type definitions

---
 js/src/framework.ts | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/js/src/framework.ts b/js/src/framework.ts
index 9d2bef9d3..bce815f8f 100644
--- a/js/src/framework.ts
+++ b/js/src/framework.ts
@@ -97,13 +97,13 @@ export type EvalData<
   Metadata extends BaseMetadata = DefaultMetadataType,
 > =
   | EvalCase<Input, Expected, Metadata>[]
-  | (() => EvalCase<Input, Expected, Metadata>[])
   | Promise<EvalCase<Input, Expected, Metadata>[]>
-  | (() => Promise<EvalCase<Input, Expected, Metadata>[]>)
-  | AsyncGenerator<EvalCase<Input, Expected, Metadata>>
   | AsyncIterable<EvalCase<Input, Expected, Metadata>>
   | BaseExperiment<Input, Expected, Metadata>
-  | (() => BaseExperiment<Input, Expected, Metadata>);
+  | (() =>
+      | EvalCase<Input, Expected, Metadata>[]
+      | Promise<EvalCase<Input, Expected, Metadata>[]>
+      | BaseExperiment<Input, Expected, Metadata>);
 
 export type EvalTask<
   Input,
@@ -111,15 +111,10 @@ export type EvalTask<
   Expected,
   Metadata extends BaseMetadata,
   Parameters extends EvalParameters,
-> =
-  | ((
-      input: Input,
-      hooks: EvalHooks<Expected, Metadata, Parameters>,
-    ) => Promise<Output>)
-  | ((
-      input: Input,
-      hooks: EvalHooks<Expected, Metadata, Parameters>,
-    ) => Output);
+> = (
+  input: Input,
+  hooks: EvalHooks<Expected, Metadata, Parameters>,
+) => Output | Promise<Output>;
 
 type TaskProgressEvent = Omit<
   SSEProgressEventData,

From 06fb7cc933b7815646fff40ba7bf4d75fbe773a5 Mon Sep 17 00:00:00 2001
From: lforst <8118419+lforst@users.noreply.github.com>
Date: Wed, 23 Sep 2026 20:47:01 +0000
Subject: [PATCH 2/2] Update PR #2516

---
 .changeset/simplify-eval-types.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/simplify-eval-types.md

diff --git a/.changeset/simplify-eval-types.md b/.changeset/simplify-eval-types.md
new file mode 100644
index 000000000..2805f7950
--- /dev/null
+++ b/.changeset/simplify-eval-types.md
@@ -0,0 +1,5 @@
+---
+"braintrust": major
+---
+
+ref!: Simplify Eval type definitions