Error when registering permission node

[xiaomian124]

My server version is Paper 1.21.10, and the plugin version is EnchantBookPlus v1.2.1
The problem happened at: "The permission enchantbookplus.enchant.multishot is already defined!"
The error message shows that the permission already exists when calling addPermission in the plugin's own Permissions.init

[20:18:41 ERROR]: Error occurred while enabling EnchantBookPlus v1.2.1 (Is it up to date?)
java.lang.IllegalArgumentException: The permission enchantbookplus.enchant.multishot is already defined!
at io.papermc.paper.plugin.manager.PaperPermissionManager.addPermission(PaperPermissionManager.java:56) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at io.papermc.paper.plugin.manager.PaperPermissionManager.addPermission(PaperPermissionManager.java:40) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.addPermission(PaperPluginManagerImpl.java:158) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at org.bukkit.plugin.SimplePluginManager.addPermission(SimplePluginManager.java:771) ~[leaves-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at EnchantBookPlus-1.2.1.jar/pro.cloudnode.smp.enchantbookplus.Permissions.init(Permissions.java:27) ~[EnchantBookPlus-1.2.1.jar:?]
at EnchantBookPlus-1.2.1.jar/pro.cloudnode.smp.enchantbookplus.EnchantBookPlus.onEnable(EnchantBookPlus.java:93) ~[EnchantBookPlus-1.2.1.jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:279) ~[leaves-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[leaves-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:644) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:601) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at net.minecraft.server.MinecraftServer.initPostWorld(MinecraftServer.java:639) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:374) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1260) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:386) ~[leaves-1.21.10.jar:1.21.10-150-dc54a2c]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

[zefir-git]

I was unable to reproduce this issue so far. I am looking into a possible fix. Did you use a plugin manager or any other tool to load/reload the plugin?

[xiaomian124]

I was unable to reproduce this issue so far. I am looking into a possible fix. Did you use a plugin manager or any other tool to load/reload the plugin?

I don’t seem to be using a plugin manager or any other loading tools, However, I do have several other plugins installed. Could the issue be related to any of the following plugins?

[zefir-git]

Can you check if this fixes the issue? EnchantBookPlus-1.2.2-pr56.1.zip (plugin JAR is inside the zip). This build comes from 97b714a on #56

[xiaomian124]

Can you check if this fixes the issue? EnchantBookPlus-1.2.2-pr56.1.zip (plugin JAR is inside the zip). This build comes from 97b714a on #56

The problem still exists, but when I tested in a new server with the same plugins as the picture above, enchantbookplus was working. I'm wondering if it's my problem.

The error is still this:

[zefir-git]

Can you confirm you fully restarted the server to update the plugin? Could you send me the server files so I can try to reproduce the issue?

[xiaomian124]

Can you confirm you fully restarted the server to update the plugin? Could you send me the server files so I can try to reproduce the issue?

I can confirm that I fully restarted the server,
This is the download link for my server files: dropbox

[zefir-git]

Just an update: I can reproduce the issue with the setup you sent, but I haven’t had the time to look into it further yet.

[vaniron]

Any chance for the fix soon? :)

[zefir-git]

Any chance for the fix soon? :)

Can you also reproduce the issue? Could you send server version and plugins list?

[zefir-git]

I think I have identified the issue. Seems to be related to custom enchantments, for example, in OPs setup, there is a nova_structures:multishot enchantment which collides with minecraft:multishot when the plugin attemps to register enchantbookplus.enchant.multishot.

I never expected this use-case, I will make it for custom enchantments to be e.g. enchantbookplus.enchant.nova_structures.multishot. For vanilla ones it stays enchantbookplus.enchant.multishot.

[zefir-git]

Working on the PR.

Related for config: #58

[zefir-git]

have not tested yet, this is from 1b9c626 on #56: EnchantBookPlus-1.2.2-pr56.2.jar.zip (jar is in the zip)

• permissions for custom enchants are like enchantbookplus.enchant.nova_structures.multishot
• config sections for custom enchants need the namespace like name: nova_structures:multishot

Would greatly appreciate it if you could help test this. Will do so myself as soon as I can find more time to continue on this