From c1e2b534bf3001628095a42c3f1f6a178af0560e Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Mon, 16 Feb 2026 18:13:32 +0100 Subject: [PATCH 1/8] replaced genootschapen with genootschappen. Only thing that remains is migrating the current database so all current genootschapen in the database are correct --- app/models/activity.rb | 2 +- spec/factories/activities.rb | 2 +- spec/models/activity_spec.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/activity.rb b/app/models/activity.rb index 083d59e2..403e9ad7 100644 --- a/app/models/activity.rb +++ b/app/models/activity.rb @@ -35,7 +35,7 @@ class Activity < ApplicationRecord def self.categories %w[algemeen societeit vorming kring - choose ifes ozon disputen genootschapen huizen extern eerstejaars] + choose ifes ozon disputen genootschappen huizen extern eerstejaars] end def full_day? diff --git a/spec/factories/activities.rb b/spec/factories/activities.rb index 63692b97..eb6d4f97 100644 --- a/spec/factories/activities.rb +++ b/spec/factories/activities.rb @@ -11,7 +11,7 @@ end_time { Faker::Time.between(from: 1.day.from_now, to: 2.days.from_now) } category do %w[algemeen societeit vorming kring - choose ifes ozon disputen genootschapen huizen extern eerstejaars].sample + choose ifes ozon disputen genootschappen huizen extern eerstejaars].sample end publicly_visible { false } diff --git a/spec/models/activity_spec.rb b/spec/models/activity_spec.rb index e761f715..33ccc967 100644 --- a/spec/models/activity_spec.rb +++ b/spec/models/activity_spec.rb @@ -180,7 +180,7 @@ let(:record) do build_stubbed(:activity, category: %w[algemeen sociëteit vorming kring - disputen genootschapen huizen extern].sample) + disputen genootschappen huizen extern].sample) end it { expect(record.humanized_category).to eq record.category.capitalize } From c555dd117d083ee434c6caf049d9186c9e790619 Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Mon, 16 Feb 2026 23:46:01 +0100 Subject: [PATCH 2/8] Added database migration --- db/migrate/20260216222433_fix_genootschapen_dyslexia.rb | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 db/migrate/20260216222433_fix_genootschapen_dyslexia.rb diff --git a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb new file mode 100644 index 00000000..8ec31874 --- /dev/null +++ b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb @@ -0,0 +1,9 @@ +class FixGenootschapenDyslexia < ActiveRecord::Migration[7.2] + def up + Activity.where(category: "Genootschapen").update_all(category: "Genootschappen") + end + + def down + Activity.where(category: "Genootschappen").update_all(category: "Genootschapen") + end +end From 82c8b369a29e50941e4f85cae1bb86ee6831e9f2 Mon Sep 17 00:00:00 2001 From: TimonBoer <93792545+TimonBoer@users.noreply.github.com> Date: Mon, 16 Feb 2026 23:58:07 +0100 Subject: [PATCH 3/8] Changed to lowercase Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- db/migrate/20260216222433_fix_genootschapen_dyslexia.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb index 8ec31874..546c8a21 100644 --- a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb +++ b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb @@ -1,9 +1,10 @@ class FixGenootschapenDyslexia < ActiveRecord::Migration[7.2] def up - Activity.where(category: "Genootschapen").update_all(category: "Genootschappen") + Activity.where(category: "genootschapen").update_all(category: "genootschappen") end def down - Activity.where(category: "Genootschappen").update_all(category: "Genootschapen") + Activity.where(category: "genootschappen").update_all(category: "genootschapen") end end +end From 46ef5dda337b529c59721a61701c114a0fb892ee Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Wed, 18 Feb 2026 09:48:40 +0100 Subject: [PATCH 4/8] added database schema --- db/schema.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/schema.rb b/db/schema.rb index 1812a52a..d13e720b 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema[7.1].define(version: 2025_11_03_104056) do +ActiveRecord::Schema[7.2].define(version: 2026_02_16_222433) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" From 5d9adb5cdf4dcf33117abdb573ba558d73cef12d Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Wed, 18 Feb 2026 10:04:00 +0100 Subject: [PATCH 5/8] oops --- db/migrate/20260216222433_fix_genootschapen_dyslexia.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb index 546c8a21..5ca7232a 100644 --- a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb +++ b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb @@ -6,5 +6,4 @@ def up def down Activity.where(category: "genootschappen").update_all(category: "genootschapen") end -end -end +end \ No newline at end of file From a3d0610b086dc25f400f5aeb37fe0fd615cdb9ac Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Wed, 18 Feb 2026 10:37:32 +0100 Subject: [PATCH 6/8] no update_all --- db/migrate/20260216222433_fix_genootschapen_dyslexia.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb index 5ca7232a..964b9646 100644 --- a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb +++ b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb @@ -1,9 +1,13 @@ class FixGenootschapenDyslexia < ActiveRecord::Migration[7.2] def up - Activity.where(category: "genootschapen").update_all(category: "genootschappen") + Activity.where(category: 'genootschapen').find_each do |activity| + activity.update!(category: 'genootschappen') + end end def down - Activity.where(category: "genootschappen").update_all(category: "genootschapen") + Activity.where(category: 'genootschappen').find_each do |activity| + activity.update!(category: 'genootschapen') + end end end \ No newline at end of file From 8840eacb1f353d7b6df34a6197207c409e08ac3f Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Wed, 18 Feb 2026 10:53:38 +0100 Subject: [PATCH 7/8] newline? --- db/migrate/20260216222433_fix_genootschapen_dyslexia.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb index 964b9646..078a9b4f 100644 --- a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb +++ b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb @@ -10,4 +10,4 @@ def down activity.update!(category: 'genootschapen') end end -end \ No newline at end of file +end From 88c42185e4f7f34f05b6b064cdd2aaa8d5360db5 Mon Sep 17 00:00:00 2001 From: Lodewiges Date: Mon, 14 Sep 2026 22:23:44 +0200 Subject: [PATCH 8/8] add agents.md --- AGENTS.md | 110 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 110 insertions(+) create mode 100644 AGENTS.md diff --git a/AGENTS.md b/AGENTS.md new file mode 100644 index 00000000..a0975bd7 --- /dev/null +++ b/AGENTS.md @@ -0,0 +1,110 @@ +# AI Dev Guide - AMBER API + +## Env +Container: `development-environment-alpha-1` +Path in container: `~/amber-api` +Shell: Must use `/bin/bash -l` for PATH +CMD: `docker exec -it development-environment-alpha-1 /bin/bash -l -c "cd ~/amber-api && bundle exec "` +Direct: Enter container, `cd ~/amber-api`, then run `bundle exec ` + +## Rules +1. Follow existing patterns +2. Tests for everything (95%+ coverage) +3. Follow RuboCop or document exception with reason +4. Keep it simple: convention over configuration +5. Don't add gems unless they have real benefit (student-maintained, avoid bloat) + +## RuboCop +Config: `.rubocop.yml` +Target: Rails 7.2, Ruby 3.3, NewCops: enable +Disabled: HttpPositionalArguments, HasManyOrHasOneDependent, InverseOf, LexicallyScopedActionFilter, RSpec/LeadingSubject, Documentation, FrozenStringLiteralComment, GuardClause +Modified: RSpec/NestedGroups Max:5, Style/ClassAndModuleChildren excludes v1 resources, Metrics/BlockLength excludes spec/** +Exceptions: Must explain why in .rubocop.yml comments + +## Structure +Resources: `app/resources/v1/*.rb` extends `V1::ApplicationResource < JSONAPI::Resource` +Tests: `spec/resources/v1/*_spec.rb` type: :resource +Factories: `spec/factories/*.rb` use FactoryBot + Faker + +## Resource Template +```ruby +# app/resources/v1/model_resource.rb +class V1::ModelResource < V1::ApplicationResource + attributes :attr1, :attr2 + has_one :user + has_many :items + filter :field + + def self.creatable_fields(context) + %i[attr1 attr2] + end + + def self.updatable_fields(context) + creatable_fields(context) + end + + def self.searchable_fields + %i[attr1 attr2] + end +end +``` + +## Test Template +```ruby +# spec/resources/v1/model_resource_spec.rb +require 'rails_helper' + +RSpec.describe V1::ModelResource, type: :resource do + let(:user) { create(:user) } + let(:context) { { user: } } + + describe '#creatable_fields' do + it { expect(described_class.creatable_fields(context)).to match_array(%i[attr1 attr2]) } + end + + describe '#updatable_fields' do + it { expect(described_class.updatable_fields(context)).to match_array(%i[attr1 attr2]) } + end +end +``` + +## Factory Template +```ruby +# spec/factories/models.rb +FactoryBot.define do + factory :model do + user + attr1 { Faker::Lorem.word } + attr2 { [true, false].sample } + end +end +``` + +## Test What +Resources: creatable_fields, updatable_fields, fetchable_fields, searchable_fields, filters, relationships, attributes, permissions +Models: validations, associations, scopes, methods, callbacks +Controllers: auth, Pundit policies, response codes, response body, error handling + +## Commands +Test all: `bundle exec rspec` +Test file: `bundle exec rspec spec/path/to/file_spec.rb` +Test line: `bundle exec rspec spec/path/to/file_spec.rb:12` +RuboCop: `bundle exec rubocop` +RuboCop fix: `bundle exec rubocop -a` +Guard: `bundle exec guard` +DB: `bundle exec rails db:migrate`, `bundle exec rails g migration Name` + +## Docker Commands +Enter: `docker exec -it development-environment-alpha-1 /bin/bash -l` then `cd ~/amber-api` +Start: `cd "C:/Users/jorai/Programeren/1. Alpha/1. Development/amber-api" && docker-compose -f docker-compose.development.yml up -d api` +Stop: `docker-compose -f docker-compose.development.yml down` +Logs: `docker logs development-environment-alpha-1` + +## Pitfalls +- Don't use `docker exec ... bundle exec ...` directly (PATH + working dir issues) +- Don't skip tests +- Don't ignore RuboCop +- Don't use hash rockets `{:key => val}` except in excluded dirs +- Don't over-engineer +- Don't use `_context` param if unused (keep it for consistency) +- Do use existing patterns from ApplicationResource for permissions