CM-71972: Resolve the skills directory at call time, not at import

CI caught a real bug. The skills directory was a module-level constant, so
Path.home() was evaluated when the module was imported - pinning it to
whatever home the process started with. A test filesystem that redirects
home could then never be seen, which is why the collection test passed on
my machine and on some runners and failed on others: it depended on
whether the fake home happened to match the real one.

Every other home-relative directory in this module is already a function
for exactly this reason, so this follows _plugins_cache_dir.

The regression test patches home and asserts the directory follows; it
fails against the old constant, so the bug cannot come back silently.

Also fixes the lint failure: a lambda returning an empty list is just list.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: Altruistus

cycode/cli/apps/ai_guardrails/ides/claude_code.py

@@ -34,7 +34,6 @@
 
 _CLAUDE_CONFIG_PATH = Path.home() / '.claude.json'
 _CLAUDE_SETTINGS_PATH = Path.home() / '.claude' / 'settings.json'
-_CLAUDE_SKILLS_DIR = Path.home() / '.claude' / 'skills'
 
 _SCAN_COMMAND = f'{CYCODE_SCAN_PROMPT_COMMAND} --ide claude-code'
 _SESSION_START_COMMAND = f'{CYCODE_SESSION_START_COMMAND} --ide claude-code'
@@ -171,6 +170,15 @@ def load_claude_settings(settings_path: Optional[Path] = None) -> Optional[dict]
         return None
 
 
+def _claude_skills_dir() -> Path:
+    """Claude Code's user-scope skills: ``~/.claude/skills/<name>/SKILL.md``.
+
+    A function, not a module constant: resolving ``Path.home()`` at import time pins the directory to
+    whatever home the process started with, which a test filesystem then cannot redirect.
+    """
+    return Path.home() / '.claude' / 'skills'
+
+
 def _plugins_cache_dir() -> Path:
     """Claude Code's local plugin content cache: ``~/.claude/plugins/cache/<marketplace>/<plugin>/<version>/``."""
     return Path.home() / '.claude' / 'plugins' / 'cache'
@@ -398,4 +406,4 @@ def get_session_context(self) -> tuple[Optional[dict], dict]:
         return global_config_file, enriched_plugins
 
     def get_skills(self) -> list[dict]:
-        return walk_skill_dirs(_CLAUDE_SKILLS_DIR)
+        return walk_skill_dirs(_claude_skills_dir())

tests/cli/commands/ai_guardrails/ides/test_skill_utils.py

@@ -2,6 +2,7 @@
 
 from pathlib import Path
 
+import pytest
 from pyfakefs.fake_filesystem import FakeFilesystem
 
 from cycode.cli.apps.ai_guardrails.ides._skill_utils import (
@@ -92,3 +93,19 @@ def test_walk_skill_dirs_truncates_at_count_cap(fs: FakeFilesystem) -> None:
         fs.create_file(root / f'skill-{index:04d}' / 'SKILL.md', contents=_BODY)
 
     assert len(walk_skill_dirs(root)) == MAX_SKILLS_PER_ROOT
+
+
+def test_walk_skill_dirs_follows_the_current_home(fs: FakeFilesystem, monkeypatch: pytest.MonkeyPatch) -> None:
+    """Regression: the skills directory must resolve when called, not when the module is imported.
+
+    It was a module-level constant, so Path.home() was captured at import and a redirected home could
+    never be seen - which passed locally and failed on CI runners whose home differed.
+    """
+    from cycode.cli.apps.ai_guardrails.ides.claude_code import ClaudeCode, _claude_skills_dir
+
+    relocated = Path('/relocated-home')
+    fs.create_file(relocated / '.claude' / 'skills' / 'moved-skill' / 'SKILL.md', contents=_BODY)
+    monkeypatch.setattr(Path, 'home', staticmethod(lambda: relocated))
+
+    assert _claude_skills_dir() == relocated / '.claude' / 'skills'
+    assert [Path(s['path']).parent.name for s in ClaudeCode().get_skills()] == ['moved-skill']

tests/cli/commands/ai_guardrails/test_session_start_command.py

@@ -39,7 +39,7 @@ def _no_local_skills(monkeypatch: pytest.MonkeyPatch) -> None:
     filesystem directly - so without this every assertion would depend on whoever ran it.
     A test that cares about skills overrides ``collect_all_skills`` itself.
     """
-    monkeypatch.setattr(_session_start_mod, 'collect_all_skills', lambda: [])
+    monkeypatch.setattr(_session_start_mod, 'collect_all_skills', list)
 
 
 # Auth tests