Skip to content

Make set_max_threads() behavior consistent with its documentation #337

Description

@tameware

python/src/bindings.cpp

Per Copilot:

set_max_threads explicitly warns that user_threads is ignored, but it still forwards the provided value to SetMaxThreads(user_threads). Even though the C API currently ignores the argument, passing it through is misleading and couples the binding to legacy behavior. Consider discarding the parameter and calling SetMaxThreads(0) (or InitializeStaticMemory()) to match the documented behavior.

This could be addressed by changing either the code or the documentation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions