From a19a0407cfed1e088ad10fd05b8e75170f79da9d Mon Sep 17 00:00:00 2001 From: Lloyd Mangnall Date: Sat, 10 Oct 2026 09:05:09 -0600 Subject: [PATCH] fix(test): parenthesize case patterns in darwin cross-compiler target `install-deps-cross-compiler-darwin` fails on macOS with "syntax error near unexpected token `;;'" because /bin/sh (bash 3.2) cannot parse a `case` with unparenthesized patterns inside `$(...)`: the pattern's closing paren ends the command substitution early. Use the POSIX leading-paren pattern form so the recipe parses under macOS /bin/sh. This also unblocks `make setup` on Apple Silicon and the linux/arm64 half of `make install`. Co-Authored-By: Claude Opus 5.5 --- t/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/Makefile b/t/Makefile index dd94069417c..4fa27970cb9 100644 --- a/t/Makefile +++ b/t/Makefile @@ -167,7 +167,7 @@ install-deps-ack-darwin: check-install-deps-homebrew-darwin .PHONY: install-deps-cross-compiler-darwin install-deps-cross-compiler-darwin: check-install-deps-homebrew-darwin @brew tap messense/macos-cross-toolchains && \ - brew install messense/macos-cross-toolchains/$$(case $$(uname -m) in arm64|aarch64) echo aarch64-unknown-linux-gnu;; x86_64) echo x86_64-unknown-linux-gnu;; esac) + brew install messense/macos-cross-toolchains/$$(case $$(uname -m) in (arm64|aarch64) echo aarch64-unknown-linux-gnu;; (x86_64) echo x86_64-unknown-linux-gnu;; esac) .PHONY: install-deps-protoc-darwin install-deps-protoc-darwin: check-install-deps-homebrew-darwin