From 8427b57f3ef2cd40459b27a92f480affa43a5bb4 Mon Sep 17 00:00:00 2001
From: ejc3 <ejc3@users.noreply.github.com>
Date: Mon, 26 Oct 2026 06:42:40 +0000
Subject: [PATCH] Use the AWS documentation placeholder instance ids in fleet
 host fixtures

Main's Bench Harness Tests failed test_no_tracked_file_anywhere_names_an_instance_volume_or_host
(run 40278845876): the host driver fixtures in src/fleet/coord/hosts.rs and
tests/test_fleet_coord.rs used made-up instance ids that match its pattern.
They now use i-0123456789abcdef0 and i-1234567890abcdef0, the placeholders the
check allows.

Tests: the check fails on main and passes here; make test-unit over
test_fleet_coord and fleet::coord::hosts passes (76 tests); make lint passes.
---
 src/fleet/coord/hosts.rs  | 16 ++++++++--------
 tests/test_fleet_coord.rs |  4 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/fleet/coord/hosts.rs b/src/fleet/coord/hosts.rs
index c1cf2ba1f..37c1aa5b0 100644
--- a/src/fleet/coord/hosts.rs
+++ b/src/fleet/coord/hosts.rs
@@ -1293,15 +1293,15 @@ mod tests {
     #[test]
     fn describe_answers_parse_to_hosts_with_their_market() {
         let xml = r#"<DescribeInstancesResponse><reservationSet><item><instancesSet>
-  <item><instanceId>i-0000000000000000a</instanceId><instanceState><code>16</code><name>running</name></instanceState>
+  <item><instanceId>i-0123456789abcdef0</instanceId><instanceState><code>16</code><name>running</name></instanceState>
     <instanceLifecycle>spot</instanceLifecycle><tagSet><item><key>Purpose</key><value>fcvm-fleet-host</value></item></tagSet></item>
-  <item><instanceId>i-0000000000000000b</instanceId><instanceState><code>0</code><name>pending</name></instanceState></item>
+  <item><instanceId>i-1234567890abcdef0</instanceId><instanceState><code>0</code><name>pending</name></instanceState></item>
 </instancesSet></item></reservationSet></DescribeInstancesResponse>"#;
         assert_eq!(
             parse_hosts(xml),
             vec![
-                host("i-0000000000000000a", "running", Market::Spot),
-                host("i-0000000000000000b", "pending", Market::OnDemand),
+                host("i-0123456789abcdef0", "running", Market::Spot),
+                host("i-1234567890abcdef0", "pending", Market::OnDemand),
             ]
         );
     }
@@ -1312,14 +1312,14 @@ mod tests {
     fn describe_answers_parse_by_item_whatever_the_field_order() {
         let xml = r#"<DescribeInstancesResponse><reservationSet><item><instancesSet>
   <item><instanceState><code>16</code><name>running</name></instanceState><instanceLifecycle>spot</instanceLifecycle>
-    <tagSet><item><key>Purpose</key><value>fcvm-fleet-host</value></item></tagSet><instanceId>i-0000000000000000a</instanceId></item>
-  <item><instanceId>i-0000000000000000b</instanceId><instanceState><code>0</code><name>pending</name></instanceState></item>
+    <tagSet><item><key>Purpose</key><value>fcvm-fleet-host</value></item></tagSet><instanceId>i-0123456789abcdef0</instanceId></item>
+  <item><instanceId>i-1234567890abcdef0</instanceId><instanceState><code>0</code><name>pending</name></instanceState></item>
 </instancesSet></item></reservationSet></DescribeInstancesResponse>"#;
         assert_eq!(
             parse_hosts(xml),
             vec![
-                host("i-0000000000000000a", "running", Market::Spot),
-                host("i-0000000000000000b", "pending", Market::OnDemand),
+                host("i-0123456789abcdef0", "running", Market::Spot),
+                host("i-1234567890abcdef0", "pending", Market::OnDemand),
             ]
         );
     }
diff --git a/tests/test_fleet_coord.rs b/tests/test_fleet_coord.rs
index 2b799333d..c4921ba3c 100644
--- a/tests/test_fleet_coord.rs
+++ b/tests/test_fleet_coord.rs
@@ -3424,7 +3424,7 @@ async fn fake_ec2_api(api: FakeEc2Api) -> String {
                         if spot && !api.spot_capacity.contains(&region) {
                             return (StatusCode::OK, "<CreateFleetResponse><fleetId>fleet-0</fleetId><errorSet><item><lifecycle>spot</lifecycle><errorCode>UnfulfillableCapacity</errorCode><errorMessage>Unable to fulfill capacity due to your request configuration.</errorMessage></item></errorSet><fleetInstanceSet/></CreateFleetResponse>".into());
                         }
-                        (StatusCode::OK, "<CreateFleetResponse><fleetId>fleet-1</fleetId><fleetInstanceSet><item><instanceIds><item>i-0fedcba9876543210</item></instanceIds></item></fleetInstanceSet></CreateFleetResponse>".into())
+                        (StatusCode::OK, "<CreateFleetResponse><fleetId>fleet-1</fleetId><fleetInstanceSet><item><instanceIds><item>i-1234567890abcdef0</item></instanceIds></item></fleetInstanceSet></CreateFleetResponse>".into())
                     }
                     _ => error("InvalidAction"),
                 }
@@ -3475,7 +3475,7 @@ async fn the_aws_host_driver_launches_through_an_instant_fleet() {
         .launch("us-east-1", Market::OnDemand, 1, "token-od")
         .await
         .unwrap();
-    assert_eq!(od.ids, vec!["i-0fedcba9876543210".to_string()]);
+    assert_eq!(od.ids, vec!["i-1234567890abcdef0".to_string()]);
     let calls = api.calls.lock().unwrap().clone();
     // The template's type is read once and reused for the second launch.
     let reads: Vec<_> = calls