The #313 merge broke dev-host ingestion in packages/plasmic-mcp, and nothing caught it.
Why CI missed it: plasmic-mcp.yml is path-gated to packages/plasmic-mcp/**. The merge touched nothing there, so MCP tests never ran.
Why types missed it: tsconfig.json has no paths mapping, so @/wab/* resolves to hand-written stubs (wab.d.ts, wab-externals.d.ts) declaring everything as unknown. tsc cannot see any upstream API change. Fixing that is #403.
What broke — upstream moved wab from ts-failable to neverthrow:
|
|
SiteCtx.change, callback fns |
now return Result, yield*-ed in safeTry → TypeError, ingestion dead |
syncCodeComponents |
returns Result; old .result.isError check was always undefined → fatal errors silently swallowed |
elementSchemaToTpl |
returns Result directly → node.add broken |
extractComponent |
returns { tplComponent, warnings } → .component undefined |
Fixtures also moved to platform/wab/playwright/bundles, and migration 258 added a required CodeComponentMeta.subtreePrefetchingConfig that the fixtures lack.
Fix: #410 — plus widening the CI path filter so upstream changes run MCP tests.
Deferred: real type resolution (#403), mutation internals (#404), enforcing the modelSchemaHash guard — currently sets isAtTip which nothing reads (#404), porting upstream's dep-CSS change into buildPreviewEntryScript.
The #313 merge broke dev-host ingestion in
packages/plasmic-mcp, and nothing caught it.Why CI missed it:
plasmic-mcp.ymlis path-gated topackages/plasmic-mcp/**. The merge touched nothing there, so MCP tests never ran.Why types missed it:
tsconfig.jsonhas nopathsmapping, so@/wab/*resolves to hand-written stubs (wab.d.ts,wab-externals.d.ts) declaring everything asunknown.tsccannot see any upstream API change. Fixing that is #403.What broke — upstream moved wab from
ts-failabletoneverthrow:SiteCtx.change, callback fnsResult,yield*-ed insafeTry→TypeError, ingestion deadsyncCodeComponentsResult; old.result.isErrorcheck was alwaysundefined→ fatal errors silently swallowedelementSchemaToTplResultdirectly →node.addbrokenextractComponent{ tplComponent, warnings }→.componentundefinedFixtures also moved to
platform/wab/playwright/bundles, and migration 258 added a requiredCodeComponentMeta.subtreePrefetchingConfigthat the fixtures lack.Fix: #410 — plus widening the CI path filter so upstream changes run MCP tests.
Deferred: real type resolution (#403), mutation internals (#404), enforcing the
modelSchemaHashguard — currently setsisAtTipwhich nothing reads (#404), porting upstream's dep-CSS change intobuildPreviewEntryScript.