Reuse shared URL component decode limits in URL builders

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/base.py

@@ -1,5 +1,5 @@
 import os
-from urllib.parse import unquote, urlparse
+from urllib.parse import urlparse
 from typing import Mapping, Optional, Type, Union
 
 from hyperbrowser.exceptions import HyperbrowserError
@@ -101,14 +101,9 @@ def _build_url(self, path: str) -> str:
         normalized_query_suffix = (
             f"?{normalized_parts.query}" if normalized_parts.query else ""
         )
-        decoded_path = normalized_path_only
-        for _ in range(10):
-            next_decoded_path = unquote(decoded_path)
-            if next_decoded_path == decoded_path:
-                break
-            decoded_path = next_decoded_path
-        else:
-            raise HyperbrowserError("path contains excessively nested URL encoding")
+        decoded_path = ClientConfig._decode_url_component_with_limit(
+            normalized_path_only, component_label="path"
+        )
         if "\\" in decoded_path:
             raise HyperbrowserError("path must not contain backslashes")
         if "\n" in decoded_path or "\r" in decoded_path:

hyperbrowser/config.py

@@ -34,6 +34,18 @@ def __post_init__(self) -> None:
             mapping_error_message="headers must be a mapping of string pairs",
         )
 
+    @staticmethod
+    def _decode_url_component_with_limit(value: str, *, component_label: str) -> str:
+        decoded_value = value
+        for _ in range(10):
+            next_decoded_value = unquote(decoded_value)
+            if next_decoded_value == decoded_value:
+                return decoded_value
+            decoded_value = next_decoded_value
+        raise HyperbrowserError(
+            f"{component_label} contains excessively nested URL encoding"
+        )
+
     @staticmethod
     def normalize_base_url(base_url: str) -> str:
         if not isinstance(base_url, str):
@@ -78,16 +90,9 @@ def normalize_base_url(base_url: str) -> str:
                 "base_url must contain a valid port number"
             ) from exc
 
-        decoded_base_path = parsed_base_url.path
-        for _ in range(10):
-            next_decoded_base_path = unquote(decoded_base_path)
-            if next_decoded_base_path == decoded_base_path:
-                break
-            decoded_base_path = next_decoded_base_path
-        else:
-            raise HyperbrowserError(
-                "base_url path contains excessively nested URL encoding"
-            )
+        decoded_base_path = ClientConfig._decode_url_component_with_limit(
+            parsed_base_url.path, component_label="base_url path"
+        )
         if "\\" in decoded_base_path:
             raise HyperbrowserError("base_url must not contain backslashes")
         if any(character.isspace() for character in decoded_base_path):