Skip to content

href-content 2.0.3 is breaking from 2.0.2 #129

Description

@azelfayyad-bri

I am using this package indirectly for a nodejs project, via html-pdf-node package, just yesterday when I reinstalled the dependencies on a development environment I got this error:

/xxxxxx/node_modules/remote-content/node_modules/axios/index.js:1
(function (exports, require, module, __filename, __dirname) { import axios from './lib/axios.js';
                                                                     ^^^^^
SyntaxError: Unexpected identifier
    at new Script (vm.js:84:7)
    at createScript (vm.js:264:10)
    at Object.runInThisContext (vm.js:312:10)
    at Module._compile (internal/modules/cjs/loader.js:694:28)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:745:10)
    at Module.load (internal/modules/cjs/loader.js:626:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:566:12)
    at Function.Module._load (internal/modules/cjs/loader.js:558:3)
    at Module.require (internal/modules/cjs/loader.js:663:17)
    at Module.Hook._require.Module.require (/usr/lib/node_modules/pm2/node_modules/require-in-the-middle/index.js:70:39)
    at Module.Hook._require.Module.require (/xxxxxx/node_modules/require-in-the-middle/index.js:188:39)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/xxxxxx/node_modules/remote-content/index.js:1:77)
    at Module._compile (internal/modules/cjs/loader.js:734:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:745:10)
    at Module.load (internal/modules/cjs/loader.js:626:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:566:12)
    at Function.Module._load (internal/modules/cjs/loader.js:558:3)
    at Module.require (internal/modules/cjs/loader.js:663:17)
    at Module.Hook._require.Module.require (/usr/lib/node_modules/pm2/node_modules/require-in-the-middle/index.js:70:39)
    at Module.Hook._require.Module.require (/xxxxxx/node_modules/require-in-the-middle/index.js:188:39)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/xxxxxx/node_modules/href-content/index.js:3:26)
    at Module._compile (internal/modules/cjs/loader.js:734:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:745:10)
    at Module.load (internal/modules/cjs/loader.js:626:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:566:12)
    at Function.Module._load (internal/modules/cjs/loader.js:558:3)
    at Module.require (internal/modules/cjs/loader.js:663:17)
    at Module.Hook._require.Module.require (/usr/lib/node_modules/pm2/node_modules/require-in-the-middle/index.js:70:39)
    at Module.Hook._require.Module.require (/xxxxxx/node_modules/require-in-the-middle/index.js:188:39)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/xxxxxx/node_modules/extract-css/index.js:5:24)
    at Module._compile (internal/modules/cjs/loader.js:734:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:745:10)
    at Module.load (internal/modules/cjs/loader.js:626:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:566:12)
    at Function.Module._load (internal/modules/cjs/loader.js:558:3)
    at Module.require (internal/modules/cjs/loader.js:663:17)
    at Module.Hook._require.Module.require (/usr/lib/node_modules/pm2/node_modules/require-in-the-middle/index.js:70:39)
    at Module.Hook._require.Module.require (/xxxxxx/node_modules/require-in-the-middle/index.js:188:39)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/xxxxxx/node_modules/inline-css/lib/inlineContent.js:1:82)
    at Module._compile (internal/modules/cjs/loader.js:734:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:745:10)
    at Module.load (internal/modules/cjs/loader.js:626:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:566:12)
    at Function.Module._load (internal/modules/cjs/loader.js:558:3)
    at Module.require (internal/modules/cjs/loader.js:663:17)
    at Module.Hook._require.Module.require (/usr/lib/node_modules/pm2/node_modules/require-in-the-middle/index.js:70:39)
    at Module.Hook._require.Module.require (/xxxxxx/node_modules/require-in-the-middle/index.js:188:39)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/xxxxxx/node_modules/inline-css/index.js:1:85)
    at Module._compile (internal/modules/cjs/loader.js:734:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:745:10)
    at Module.load (internal/modules/cjs/loader.js:626:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:566:12)
    at Function.Module._load (internal/modules/cjs/loader.js:558:3)
    at Module.require (internal/modules/cjs/loader.js:663:17)
    at Module.Hook._require.Module.require (/usr/lib/node_modules/pm2/node_modules/require-in-the-middle/index.js:70:39)
    at Module.Hook._require.Module.require (/xxxxxx/node_modules/require-in-the-middle/index.js:188:39)
    at require (internal/modules/cjs/helpers.js:20:18)

I compared my production build with the development build and noticed that href-content changing from version 2.0.2 to 2.0.3 breaks my project, I think because some of its dependency upgrades axios version to a breaking version and causes the error. Related dependency tree: html-pdf-node@1.0.8 > inline-css@3.0.0 > extract-css@2.0.1 > href-content@2.0.3

My environment:
npm: 6.5.0
node: 11.9.0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions