From 12b87ef286a60b39dc08bac1e78305c19c989441 Mon Sep 17 00:00:00 2001 From: zethson Date: Wed, 14 Aug 2024 10:57:50 +0200 Subject: [PATCH 1/3] :sparkles: Add require-empty flag for deletion Signed-off-by: zethson --- lamin_cli/__main__.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lamin_cli/__main__.py b/lamin_cli/__main__.py index 400b73bc..96344b65 100644 --- a/lamin_cli/__main__.py +++ b/lamin_cli/__main__.py @@ -163,12 +163,13 @@ def close(): @main.command() @click.argument("instance", type=str, default=None) @click.option("--force", is_flag=True, default=False, help="Do not ask for confirmation.") # noqa: E501 +@click.option('--require-empty/--no-require-empty', default=True, help="Whether the instance must be empty for deletion.") # fmt: on -def delete(instance: str, force: bool = False): +def delete(instance: str, force: bool = False, require_empty=True): """Delete an instance.""" from lamindb_setup._delete import delete - return delete(instance, force=force) + return delete(instance, force=force, require_empty=require_empty) @main.command() From 2637dff78f86c19fb64435b1b51c47bfe59034a4 Mon Sep 17 00:00:00 2001 From: Lukas Heumos Date: Wed, 14 Aug 2024 16:00:57 +0200 Subject: [PATCH 2/3] add missing type --- lamin_cli/__main__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lamin_cli/__main__.py b/lamin_cli/__main__.py index 96344b65..cdf4d754 100644 --- a/lamin_cli/__main__.py +++ b/lamin_cli/__main__.py @@ -165,7 +165,7 @@ def close(): @click.option("--force", is_flag=True, default=False, help="Do not ask for confirmation.") # noqa: E501 @click.option('--require-empty/--no-require-empty', default=True, help="Whether the instance must be empty for deletion.") # fmt: on -def delete(instance: str, force: bool = False, require_empty=True): +def delete(instance: str, force: bool = False, require_empty: bool = True): """Delete an instance.""" from lamindb_setup._delete import delete From 9cad79eb7cc3560cf159cf48d3ebcf4ce4e0e7bd Mon Sep 17 00:00:00 2001 From: zethson Date: Fri, 16 Aug 2024 10:27:57 +0200 Subject: [PATCH 3/3] :art: Confirm/no-confirm Signed-off-by: zethson --- lamin_cli/__main__.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lamin_cli/__main__.py b/lamin_cli/__main__.py index 96344b65..d8e29286 100644 --- a/lamin_cli/__main__.py +++ b/lamin_cli/__main__.py @@ -162,14 +162,13 @@ def close(): # fmt: off @main.command() @click.argument("instance", type=str, default=None) -@click.option("--force", is_flag=True, default=False, help="Do not ask for confirmation.") # noqa: E501 -@click.option('--require-empty/--no-require-empty', default=True, help="Whether the instance must be empty for deletion.") +@click.option("--confirm/--no-confirm", default=True, help="Whether to ask for confirmation.") # noqa: E501 # fmt: on -def delete(instance: str, force: bool = False, require_empty=True): +def delete(instance: str, confirm: bool = True): """Delete an instance.""" from lamindb_setup._delete import delete - return delete(instance, force=force, require_empty=require_empty) + return delete(instance, force=not confirm) @main.command()