Skip to content

Mismatch between Fig. 4 (Feature Extractor Module) of paper and implementaion #129

Description

@baharangostaromid-hash

Hi and thanks for your great work

In figure 4 of the paper, we have this diagram for Feature Extractor module:

Image

The second part (four DC block) takes $F_{t-1}^e$ as input right? but in the implementation:

    def forward(self, x, quant):
        x1, ctx_t = self.forward_part1(x, quant)
        ctx = self.forward_part2(x1)
        return ctx, ctx_t

you passed x1 (output of first part BEFORE multiplying by $q_f$

why?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions