From 0c51cb215b606e9686a2dcbd9daad73159831c3b Mon Sep 17 00:00:00 2001 From: Abdullah Mohammd Sifat Date: Mon, 16 Nov 2026 15:27:39 +0600 Subject: [PATCH] Implement URL validation to prevent SSRF Added a function to validate that URLs do not resolve to private or reserved IP addresses, preventing SSRF vulnerabilities. --- .../handlers/web_handler/web_handler.py | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/mindsdb/integrations/handlers/web_handler/web_handler.py b/mindsdb/integrations/handlers/web_handler/web_handler.py index 4956d2f054..e2069271a9 100644 --- a/mindsdb/integrations/handlers/web_handler/web_handler.py +++ b/mindsdb/integrations/handlers/web_handler/web_handler.py @@ -1,4 +1,7 @@ +import ipaddress +import socket from typing import List +from urllib.parse import urlparse import pandas as pd from mindsdb.integrations.libs.response import HandlerStatusResponse @@ -10,6 +13,42 @@ from mindsdb.integrations.utilities.sql_utils import FilterCondition, FilterOperator +def _validate_no_private_ip(url: str) -> None: + """ + Validates that the given URL does not resolve to a loopback, private, + link-local, multicast, or reserved IP address to prevent SSRF. + """ + parsed = urlparse(url) + hostname = parsed.hostname + if not hostname: + raise ValueError(f"Invalid URL provided: {url}") + + try: + addr_info = socket.getaddrinfo(hostname, None) + except socket.gaierror as e: + raise ValueError(f"Could not resolve hostname for URL '{url}': {e}") + + for info in addr_info: + ip_str = info[4][0] + try: + ip_obj = ipaddress.ip_address(ip_str) + if ( + ip_obj.is_private + or ip_obj.is_loopback + or ip_obj.is_link_local + or ip_obj.is_reserved + or ip_obj.is_multicast + or ip_obj.is_unspecified + ): + raise ValueError( + f"Access to private, loopback, or reserved IP addresses is forbidden: {url} ({ip_str})" + ) + except ValueError as ve: + if "forbidden" in str(ve): + raise + continue + + class CrawlerTable(APIResource): def list(self, conditions: List[FilterCondition] = None, limit: int = None, **kwargs) -> pd.DataFrame: """ @@ -47,6 +86,9 @@ def list(self, conditions: List[FilterCondition] = None, limit: int = None, **kw 'You must specify what url you want to crawl, for example: SELECT * FROM web.crawler WHERE url = "someurl"' ) + for url in urls: + _validate_no_private_ip(url) + allowed_urls = config.get("web_crawling_allowed_sites", []) if allowed_urls and not validate_urls(urls, allowed_urls): raise ValueError( @@ -96,3 +138,4 @@ def check_connection(self) -> HandlerStatusResponse: """ response = HandlerStatusResponse(True) return response +