Makefile

.DEFAULT_GOAL := help

# CGO_ENABLED=0 is not FIPS compliant. large commercial vendors and FedRAMP require FIPS compliant crypto
# Use ?= so callers can override on the command line, e.g. CGO_ENABLED=0 make build for a non-FIPS static binary
CGO_ENABLED ?= 1
GOEXPERIMENT ?= boringcrypto
GOFIPS140 ?= off

GO ?= go
TOOL_MOD := tools/go.mod
gotool = "$(GO)" tool -modfile="$(TOOL_MOD)" $(1)
GOFMT ?= gofmt
# Keep promtool out of tools/go.mod: it pulls Prometheus' large server dependency graph.
PROMTOOL := github.com/prometheus/prometheus@v0.304.2

# Binary output directory and name
BIN_DIR := bin
BINARY_NAME := $(BIN_DIR)/hyperfleet-adapter

# Version information
BUILD_DATE ?= $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
GIT_SHA ?= $(shell git rev-parse --short HEAD 2>/dev/null || echo "unknown")
GIT_DIRTY ?= $(shell [ -z "$$(git status --porcelain 2>/dev/null)" ] || echo "-modified")
APP_VERSION ?= $(shell git describe --tags --always --dirty 2>/dev/null || echo "0.0.0-dev")

# Go build flags
GOFLAGS ?= -trimpath
VERSION_PKG := github.com/openshift-hyperfleet/hyperfleet-adapter/pkg/version
LDFLAGS := -s -w \
           -X $(VERSION_PKG).Version=$(APP_VERSION) \
           -X $(VERSION_PKG).Commit=$(GIT_SHA) \
           -X $(VERSION_PKG).BuildDate=$(BUILD_DATE)

# Container tool (docker or podman)
CONTAINER_TOOL ?= $(shell command -v podman 2>/dev/null || command -v docker 2>/dev/null)

# Container build configuration
PLATFORM ?= linux/amd64
DEV_BASE_IMAGE ?= registry.access.redhat.com/ubi9/ubi-minimal:latest

# =============================================================================
# Image Configuration
# =============================================================================
IMAGE_REGISTRY ?= quay.io/openshift-hyperfleet
IMAGE_NAME ?= hyperfleet-adapter
IMAGE_TAG ?= $(APP_VERSION)

# Dev image configuration - set QUAY_USER to push to personal registry
# Usage: QUAY_USER=myuser make image-dev
QUAY_USER ?=
DEV_TAG ?= dev-$(GIT_SHA)

# Test parameters
TEST_TIMEOUT := 30m

.PHONY: help
help: ## Display this help
	@awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n  make \033[36m<target>\033[0m\n"} /^[a-zA-Z0-9_-]+:.*?##/ { printf "  \033[36m%-22s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST)

##@ Development

.PHONY: build
build: ## Build the adapter binary
	@mkdir -p $(BIN_DIR)
	CGO_ENABLED=$(CGO_ENABLED) GOEXPERIMENT=$(GOEXPERIMENT) GOFIPS140=$(GOFIPS140) $(GO) build $(GOFLAGS) -ldflags "$(LDFLAGS)" -o $(BINARY_NAME) ./cmd/adapter

.PHONY: install
install: build ## Build and install binary to GOPATH/bin
	CGO_ENABLED=$(CGO_ENABLED) GOEXPERIMENT=$(GOEXPERIMENT) GOFIPS140=$(GOFIPS140) $(GO) install $(GOFLAGS) -ldflags "$(LDFLAGS)" ./cmd/adapter

.PHONY: clean
clean: ## Remove build artifacts
	rm -rf $(BIN_DIR)
	rm -f coverage.out coverage.html

##@ Testing

.PHONY: test
test: test-alerts ## Run unit tests with race detection
	$(GO) test -v -race -coverprofile=coverage.out -timeout $(TEST_TIMEOUT) \
		$$($(GO) list ./... | grep -v /test/)

.PHONY: promtool
promtool: ## Build the pinned promtool binary
	@mkdir -p $(BIN_DIR)
	$(GO) mod download $(PROMTOOL)
	cd "$$($(GO) env GOMODCACHE)/$(PROMTOOL)" && \
		$(GO) build -o "$(CURDIR)/$(BIN_DIR)/promtool" ./cmd/promtool

.PHONY: test-alerts
test-alerts: promtool ## Test Prometheus alert rules
	$(BIN_DIR)/promtool test rules test/alerts/*_test.yaml

.PHONY: test-coverage
test-coverage: test ## Run tests and show coverage
	$(GO) tool cover -html=coverage.out

.PHONY: test-integration
test-integration: ## Run integration tests (requires Docker/Podman)
	@TEST_TIMEOUT=$(TEST_TIMEOUT) bash scripts/run-integration-tests.sh

.PHONY: image-integration-test
image-integration-test: ## Build integration test image with envtest
	@bash scripts/build-integration-image.sh

.PHONY: test-all
test-all: lint test test-alerts test-integration test-helm ## Run all checks (lint, unit, alerts, integration, helm)

##@ Helm Charts

.PHONY: helm-docs
helm-docs: ## Generate Helm chart README from values.yaml annotations
	$(call gotool,helm-docs) --chart-search-root=charts --sort-values-order=file

.PHONY: verify-helm-docs
verify-helm-docs: ## Verify chart README is up to date
	$(call gotool,helm-docs) --chart-search-root=charts --sort-values-order=file
	@git diff --exit-code charts/README.md > /dev/null 2>&1 || \
		(echo "ERROR: charts/README.md is out of date. Run 'make helm-docs' and commit the result." && exit 1)

# kubeconform flags for validating rendered Helm templates against Kubernetes
# and CRD schemas. Uses the datreeio/CRDs-catalog for ServiceMonitor schemas.
KUBECONFORM_FLAGS := \
	-strict \
	-kubernetes-version 1.30.0 \
	-schema-location default \
	-schema-location 'https://raw.githubusercontent.com/datreeio/CRDs-catalog/main/{{.Group}}/{{.ResourceKind}}_{{.ResourceAPIVersion}}.json'

.PHONY: test-helm
test-helm: verify-helm-docs ## Test Helm charts (lint, template, validate, kubeconform)
	@if ! command -v helm > /dev/null; then \
		echo "ERROR: helm not found. Please install Helm:"; \
		echo "  brew install helm  # macOS"; \
		echo "  curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash  # Linux"; \
		exit 1; \
	fi
	@echo "Linting Helm chart..."
	helm lint charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test
	@echo ""
	@echo "Testing template rendering with minimal required values..."
	helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "Minimal required values template OK"
	@echo ""
	@echo "Testing template with broker enabled..."
	@output=$$(helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.create=true \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set broker.googlepubsub.expirationTTL=1d \
		--set broker.googlepubsub.messageRetentionDuration=12h \
		--set broker.type=googlepubsub) \
		&& echo "$$output" | grep -q 'type: googlepubsub' \
		|| { echo "ERROR: expected googlepubsub broker type in rendered output"; exit 1; }; \
		echo "$$output" | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "Broker config template OK"
	@echo ""
	@echo "Testing template with HyperFleet API config..."
	helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set adapterConfig.hyperfleetApi.baseUrl=http://localhost:8000 \
		--set adapterConfig.hyperfleetApi.version=v1 | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "HyperFleet API config template OK"
	@echo ""
	@echo "Testing template with PDB enabled..."
	helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set podDisruptionBudget.enabled=true \
		--set podDisruptionBudget.minAvailable=1 \
		--set podDisruptionBudget.maxUnavailable=null | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "PDB config template OK"
	@echo ""
	@echo "Testing template with autoscaling..."
	helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set autoscaling.enabled=true \
		--set autoscaling.minReplicas=2 \
		--set autoscaling.maxReplicas=5 | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "Autoscaling config template OK"
	@echo ""
	@echo "Testing template with probes enabled..."
	helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set livenessProbe.enabled=true \
		--set readinessProbe.enabled=true \
		--set startupProbe.enabled=true | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "Probes config template OK"
	@echo ""
	@echo "Testing template with ServiceMonitor enabled..."
	@output=$$(helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set monitoring.serviceMonitor.enabled=true \
		--api-versions monitoring.coreos.com/v1/ServiceMonitor) \
		&& echo "$$output" | grep -q 'kind: ServiceMonitor' \
		|| { echo "ERROR: ServiceMonitor not rendered"; exit 1; }; \
		echo "$$output" | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "ServiceMonitor enabled template OK"
	@echo ""
	@echo "Testing template with ServiceMonitor enabled but CRD unavailable..."
	@output=$$(helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set monitoring.serviceMonitor.enabled=true) \
		&& ! echo "$$output" | grep -q 'kind: ServiceMonitor' \
		|| { echo "ERROR: ServiceMonitor rendered without CRD"; exit 1; }; \
		echo "$$output" | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "ServiceMonitor CRD-missing template OK"
	@echo ""
	@echo "Testing template with ServiceMonitor disabled..."
	@output=$$(helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set monitoring.serviceMonitor.enabled=false \
		--api-versions monitoring.coreos.com/v1/ServiceMonitor) \
		&& ! echo "$$output" | grep -q 'kind: ServiceMonitor' \
		|| { echo "ERROR: ServiceMonitor rendered while disabled"; exit 1; }; \
		echo "$$output" | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "ServiceMonitor disabled template OK"
	@echo ""
	@echo "Testing template with RabbitMQ broker..."
	@output=$$(helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.create=true \
		--set broker.type=rabbitmq \
		--set broker.rabbitmq.url=amqp://guest:guest@rabbitmq:5672/ \
		--set broker.rabbitmq.exchange=test-exchange) \
		&& echo "$$output" | grep -q 'type: rabbitmq' \
		|| { echo "ERROR: expected rabbitmq broker type in rendered output"; exit 1; }; \
		echo "$$output" | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "RabbitMQ broker template OK"
	@echo ""
	@echo "Testing that rabbitmq broker.type with both sections set selects rabbitmq..."
	@output=$$(helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.create=true \
		--set broker.type=rabbitmq \
		--set broker.rabbitmq.url=amqp://guest:guest@rabbitmq:5672/ \
		--set broker.rabbitmq.exchange=test-exchange \
		--set broker.googlepubsub.projectId=my-project \
		--set broker.googlepubsub.topic=my-topic \
		--set broker.googlepubsub.subscriptionId=my-sub) \
		&& echo "$$output" | grep -q 'type: rabbitmq' \
		|| { echo "ERROR: expected rabbitmq broker type in output"; exit 1; }; \
		echo "$$output" | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS)
	@echo "RabbitMQ broker type selection OK"
	@echo ""
	@echo "Testing that rabbitmq renders OK without queue (queue is optional)..."
	@helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.create=true \
		--set broker.type=rabbitmq \
		--set broker.rabbitmq.url=amqp://guest:guest@rabbitmq:5672/ \
		--set broker.rabbitmq.exchange=test-exchange > /dev/null \
		|| { echo "ERROR: helm template failed when broker.rabbitmq.queue is omitted (queue should be optional)"; exit 1; }
	@echo "RabbitMQ optional queue validation OK"
	@echo ""
	@echo "Testing that rabbitmq without exchange fails validation..."
	@if helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.create=true \
		--set broker.type=rabbitmq \
		--set broker.rabbitmq.url=amqp://guest:guest@rabbitmq:5672/ \
		--set broker.rabbitmq.queue=test-queue > /dev/null 2>&1; then \
		echo "ERROR: expected helm template to fail when broker.rabbitmq.exchange is missing"; exit 1; \
	fi
	@echo "RabbitMQ missing exchange validation OK"
	@echo ""
	@echo "Testing Pub/Sub messageRetentionDuration=31d (max) is accepted..."
	@helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set broker.googlepubsub.messageRetentionDuration=31d > /dev/null \
		|| { echo "ERROR: helm template failed for messageRetentionDuration=31d"; exit 1; }
	@echo "Pub/Sub 31d retention validation OK"
	@echo ""
	@echo "Testing Pub/Sub expirationTTL=86400s (1d) is accepted..."
	@helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set broker.googlepubsub.expirationTTL=86400s > /dev/null \
		|| { echo "ERROR: helm template failed for expirationTTL=86400s"; exit 1; }
	@echo "Pub/Sub 86400s TTL validation OK"
	@echo ""
	@echo "Testing Pub/Sub numeric-zero messageRetentionDuration is rejected..."
	@if helm template test-release charts/ \
		--set image.registry=quay.io \
		--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
		--set image.tag=test \
		--set adapterConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set adapterTaskConfig.yaml="apiVersion: hyperfleet.redhat.com/v1alpha1" \
		--set broker.type=googlepubsub \
		--set broker.googlepubsub.subscriptionId=test-sub \
		--set broker.googlepubsub.topic=test-topic \
		--set broker.googlepubsub.messageRetentionDuration=0 > /dev/null 2>&1; then \
		echo "ERROR: expected helm template to fail when messageRetentionDuration=0"; exit 1; \
	fi
	@echo "Pub/Sub zero retention validation OK"
	@for values in charts/examples/*/values.yaml; do \
		echo "Rendering $$values example overlay..."; \
		output=$$(helm template example charts/ -f "$$values" \
			--set image.registry=quay.io \
			--set image.repository=openshift-hyperfleet/hyperfleet-adapter \
			--set image.tag=test) || exit 1; \
		echo "$$output" | $(call gotool,kubeconform) $(KUBECONFORM_FLAGS) || exit 1; \
	done

##@ Code Quality

.PHONY: install-hooks
install-hooks: ## Install pre-commit hooks
	pre-commit install

.PHONY: fmt
fmt: ## Format code with goimports
	$(call gotool,goimports) -w .

.PHONY: gofmt
gofmt: fmt ## Alias for fmt

.PHONY: fmt-check
fmt-check: ## Check if code is formatted
	@diff=$$($(GOFMT) -s -d .); \
	if [ -n "$$diff" ]; then \
		echo "Code is not formatted. Run 'make fmt' to fix:"; \
		echo "$$diff"; \
		exit 1; \
	fi

.PHONY: vet
vet: ## Run go vet
	$(GO) vet ./...

.PHONY: go-vet
go-vet: vet ## Alias for vet

.PHONY: lint
lint: ## Run golangci-lint
	$(call gotool,golangci-lint) run ./...

.PHONY: tools
tools: ## Ensure tool dependencies are up to date
	cd tools && "$(GO)" mod tidy

.PHONY: verify-tools
verify-tools: tools ## Fail if tool module drifted
	@git diff --exit-code HEAD -- tools/go.mod tools/go.sum || (echo "tool modules out of date; run 'make tools'" && exit 1)

.PHONY: verify
verify: fmt-check vet ## Run all verification checks

##@ Dependencies

.PHONY: tidy
tidy: ## Tidy go.mod
	$(GO) mod tidy

.PHONY: download
download: ## Download dependencies
	$(GO) mod download


##@ Container Images

.PHONY: check-container-tool
check-container-tool:
ifndef CONTAINER_TOOL
	@echo "Error: No container tool found (podman or docker)"
	@echo ""
	@echo "Please install one of:"
	@echo "  brew install podman   # macOS"
	@echo "  brew install docker   # macOS"
	@echo "  dnf install podman    # Fedora/RHEL"
	@exit 1
endif

.PHONY: image
image: check-container-tool ## Build container image
	@echo "Building image $(IMAGE_REGISTRY)/$(IMAGE_NAME):$(IMAGE_TAG) ..."
	$(CONTAINER_TOOL) build \
		--platform $(PLATFORM) \
		--build-arg GIT_SHA=$(GIT_SHA) \
		--build-arg GIT_DIRTY=$(GIT_DIRTY) \
		--build-arg BUILD_DATE=$(BUILD_DATE) \
		--build-arg APP_VERSION=$(APP_VERSION) \
		-t $(IMAGE_REGISTRY)/$(IMAGE_NAME):$(IMAGE_TAG) .
	@echo "Image built: $(IMAGE_REGISTRY)/$(IMAGE_NAME):$(IMAGE_TAG)"

.PHONY: image-push
image-push: check-container-tool image ## Build and push container image
	@echo "Pushing image $(IMAGE_REGISTRY)/$(IMAGE_NAME):$(IMAGE_TAG) ..."
	$(CONTAINER_TOOL) push $(IMAGE_REGISTRY)/$(IMAGE_NAME):$(IMAGE_TAG)
	@echo "Image pushed: $(IMAGE_REGISTRY)/$(IMAGE_NAME):$(IMAGE_TAG)"

.PHONY: image-dev
image-dev: check-container-tool ## Build and push to personal Quay registry (requires QUAY_USER)
ifndef QUAY_USER
	@echo "Error: QUAY_USER is not set"
	@echo ""
	@echo "Usage: QUAY_USER=myuser make image-dev"
	@echo ""
	@echo "This will build and push to: quay.io/$$QUAY_USER/$(IMAGE_NAME):$(DEV_TAG)"
	@exit 1
endif
	@echo "Building dev image quay.io/$(QUAY_USER)/$(IMAGE_NAME):$(DEV_TAG) ..."
	$(CONTAINER_TOOL) build \
		--platform $(PLATFORM) \
		--build-arg BASE_IMAGE=$(DEV_BASE_IMAGE) \
		--build-arg GIT_SHA=$(GIT_SHA) \
		--build-arg GIT_DIRTY=$(GIT_DIRTY) \
		--build-arg BUILD_DATE=$(BUILD_DATE) \
		--build-arg APP_VERSION=0.0.0-dev \
		-t quay.io/$(QUAY_USER)/$(IMAGE_NAME):$(DEV_TAG) .
	@echo "Pushing dev image..."
	$(CONTAINER_TOOL) push quay.io/$(QUAY_USER)/$(IMAGE_NAME):$(DEV_TAG)
	@echo ""
	@echo "Dev image pushed: quay.io/$(QUAY_USER)/$(IMAGE_NAME):$(DEV_TAG)"