Skip to content

Bug: ProgressDeadlineExceeded not set for CE-level resolution/apply failures #2861

Description

@joelanford

Consider this scenario:

  1. At T0, user creates a CE, which leads to a successful installation:
  • Progressing=True/Succeeded
  • lastTransitionTime=T0
  1. Much later at T100, user modifies the CE to ask for a non-existent version:
  • Progressing=True/Retrying
  • lastTransitionTime=T0 (because this only changes when status changes)

What currently happens at T100+progressDeadlineMinutes is.... nothing. We should exceed the deadline at that point, but there is nothing in the CE API anywhere that records when we've actually started progressing from steady state again.

If we change (1) such that it results in Progressing=False/Succeeded, then (2) would transition to Progressing=True, which means lastTransitionTime would also be set to T100, which would mean would could close that scenario's progressing deadline bug by setting Progressing=False/ProgressDeadlineExceeded, which we wouldn't subsequently change until we successfully resolve/apply the COS again.

Originally posted by @joelanford in #2810 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions