Skip to content

backlog-burndown: the in-flight verification names no command to enumerate the open feature pull requests #1308

Description

@ptr727

backlog-burndown "Grouping and File Claims" verifies a predicted group against everything in flight, and one of its inputs is "the files changed by every open feature pull request on this repository (gh pr diff <number> --name-only per open pull request)".

Every other input in that bullet carries the command that produces it: git worktree list for registered worktrees, git branch -r after git fetch --prune origin for a pushed branch whose worktree is gone, git branch for one never pushed. The pull request input names the per-pull-request command and no command that enumerates <number> across the open set, so the one input feeding the widest read is the one a reader has to improvise. An improvised enumeration is also where the feature qualifier gets lost, since the open set includes the promotion pull request, whose diff is the whole of develop against main and would collide with every group.

The fix is one clause naming the listing command and the filter that drops the promotion pull request from it.

Raised by copilot-pull-request-reviewer on the develop -> main promotion pull request #1304, and deferred there under the maintainer's instruction to merge the promotion and take the findings up afterwards. Adjacent to #1275, which covers four other defects in this same enumeration bullet and not this one.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    proseA defect in rule or procedure text

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions