fix: refuse the resource parameter removed from delete and modify

Author: azmeuk

doc/changelog.rst

@@ -1,6 +1,15 @@
 Changelog
 =========
 
+[0.13.1] - Unreleased
+---------------------
+
+Fixed
+^^^^^
+- Until 1.0, ``delete`` and ``modify`` raise a :class:`TypeError` when they are given the
+  ``resource`` parameter removed in 0.13. It used to be passed to the HTTP library, and the request
+  failed with a misleading "No resource type" error.
+
 [0.13.0] - 2026-10-08
 ---------------------
 

scim2_client/client.py

@@ -80,6 +80,19 @@
 _ME_ENDPOINT = "/Me"
 
 
+def _refuse_resource_parameter(operation: str, kwargs: dict[str, Any]) -> None:
+    """Refuse the ``resource`` parameter that ``delete`` and ``modify`` took until 0.12.
+
+    It would otherwise be passed to the HTTP library, and the request would lack its target.
+    Will be removed in 1.0.
+    """
+    if "resource" in kwargs:
+        raise TypeError(
+            f"{operation}() got an unexpected keyword argument 'resource'. "
+            "Pass the resource as target."
+        )
+
+
 class _Me:
     """The resource of the authenticated client, reached under ``/Me`` (:rfc:`RFC 7644 §3.11 <7644#section-3.11>`).
 
@@ -1506,6 +1519,7 @@ def _prepare_delete_request(
         expected_status_codes: list[int] | None = None,
         **kwargs: Any,
     ) -> RequestPayload:
+        _refuse_resource_parameter("delete", kwargs)
         url, _, instance = self._locate_resource(target, id, "delete")
         req = RequestPayload(
             expected_status_codes=expected_status_codes,
@@ -1572,6 +1586,7 @@ def _prepare_patch_request(
         **kwargs: Any,
     ) -> RequestPayload:
         """Prepare a PATCH request payload."""
+        _refuse_resource_parameter("modify", kwargs)
         # The id is optional, so the patch operation may take its place.
         if not isinstance(id, str | Resource | None):
             if patch_op is not None:

tests/test_resource_types.py

@@ -439,6 +439,13 @@ def test_patch_operation_passed_twice_is_refused(client):
         client.modify(User, patch_op, patch_op)
 
 
+@pytest.mark.parametrize("operation", ["delete", "modify"])
+def test_resource_parameter_is_refused(client, operation):
+    """The resource parameter removed in 0.13 is refused instead of being passed to the HTTP library."""
+    with pytest.raises(TypeError, match="Pass the resource as target"):
+        getattr(client, operation)(resource=User, id="123")
+
+
 def test_search_reaches_the_resource_type_of_a_model(httpserver, client):
     """Test that a search under a model is sent to the endpoint of its resource type."""
     httpserver.expect_request("/Users/.search", method="POST").respond_with_json(