Skip to content

@sajari/react-search-ui does not list classnames as a dependency #882

Description

@neongreen

@sajari/react-search-ui uses import ... 'classnames', but doesn't list it in its dependencies — I suppose it assumes it can get it by virtue of having it as a dependency of @sajari/react-components.

However, this is not the case when using eg. Yarn with nodeLinker: pnpm, or maybe even default Yarn. A package depending on @sajari/react-search-ui will fail to build. At least for me it does.

I think @emotion/css and @emotion/core dependencies should also be added.

image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions