Skip to content

Ideas for perf improvements on long strings #26

Description

@tjmehta

Hello @sallar,

Thanks for this great library! My application can potentially be running ‘substr’ on many long strings at the same time, so perf is very important. I noticed that ‘substr’ (etc) uses ‘match’ which runs the RegExp on the entire string. This can be quite expensive for long string especially if ‘substr’s ‘length’ is much shorter than the entire string.

So far I only have one idea: to use ‘exec’ with a while loop in the case that ‘length’ is much shorter than the entire ‘string’*. Do you have any other ideas for perf improvements? I would be happy to implement them and send you PRs.

*See benchmarks: https://jsperf.com/regex-exec-vs-match-for-long-strings/1

Thanks

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions