Fix Attachments on mobile

[Tourniquet88]

Since a long time Attachments on mobile do not work. I now know why:

The problem is, as soon as you open the file picker on mobile the app suspends. Even if its just for a short time. When you select the picture / file you want to send, you go back to the conversation view. Now you can see for a splitsecond the attachment, but it will get removed because for whatever reason the "public void Load(SignalConversation conversation)" is being called and with that you "ResetInput();" everything, hence the Attachment is going to be removed right away.

Sadly I do not know why the Load procedure is being called. On my end I added a stupid workaround with a bool "NeedToSendAttachment" in the load procedure to prevent it to "ResetInput" when you're attaching a file. It's not a (good) fix.

At least I'm now able to send Attachments from my Lumia :)

Would be nice if that gets properly fixed in the future though.

[clemensott]

The Load function ("public void Load(SignalConversation conversation)") gets call because of "App_Resuming" in App.xam.cs. I'm not sure what would be the best solution, but I solved it by not calling ResetInput() when the ThreadIds of the old and new conversations are the same.

bool conversationThreadIdChanged = SignalConversation?.ThreadId != conversation?.ThreadId;

[...]

if (conversationThreadIdChanged)
{
    LastMarkReadRequest = -1;
    SendButtonEnabled = false;
    ResetInput();
}

I'm not sure if not setting LastMarkReadRequest and SendButtonEnabled is a good idea.

[golf1052]

I've started looking at fixing attachments. This PR signal-csharp/libsignal-service-dotnet#45 goes over what is needed to get them working again.

[Tourniquet88]

I've started looking at fixing attachments. This PR signal-csharp/libsignal-service-dotnet#45 goes over what is needed to get them working again.

That's actually not related to this mobile problem though? The issue was specifically a mobile issue that was related to the Keyboad popup which always resets the "input" model so that you can't actually send an attachment, because it was reset all the time?

[golf1052]

This should be fixed in 0.3.1 which is now in the store. Can you update and check that this works?