From de01ce5d1310a2d575de20db48407a8fdd541e84 Mon Sep 17 00:00:00 2001 From: thatssoheil Date: Sun, 13 Sep 2026 11:27:40 -0400 Subject: [PATCH] chore(ci): run the nightly-only checks again and raise the serde floor ci/test-stable.sh gated its benchmark and minimal-versions checks on a RUST_VERSION environment variable that no workflow sets, so those two checks have not run in CI since #452. Gate on the toolchain actually in use instead: the nightly job switches the default toolchain before it runs the script, so `rustc --version` is the authority and cannot go stale. Running the check for the first time fails on the serde floor this crate declares: -Z minimal-versions resolves serde 1.0.60, whose alloc feature does not compile under it (E0432, unresolved imports alloc::BTreeMap, BTreeSet, BinaryHeap, LinkedList and VecDeque). 1.0.69 fails identically and 1.0.70 compiles, so the floor becomes 1.0.70. Verified locally with the nightly toolchain: cargo +nightly update -Z minimal-versions && cargo +nightly check --all-features cargo +nightly check --benches both succeed at floor 1.0.70 and fail at 1.0.69. The stable matrix is unaffected: cargo test, cargo test --all-features and cargo test --no-default-features --features serde all pass. Disclosure: AI-assisted (Hermes Agent, Nous Research); both claims above were re-checked against the real toolchains before this commit. --- Cargo.toml | 2 +- ci/test-stable.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 3fe858369..15564def5 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -24,7 +24,7 @@ default = ["std"] std = [] [dependencies] -serde = { version = "1.0.60", optional = true, default-features = false, features = ["alloc"] } +serde = { version = "1.0.70", optional = true, default-features = false, features = ["alloc"] } # Use portable-atomic crate to support platforms without atomic CAS. # See "no_std support" section in readme for more information. # diff --git a/ci/test-stable.sh b/ci/test-stable.sh index ad9757449..b6df1b585 100755 --- a/ci/test-stable.sh +++ b/ci/test-stable.sh @@ -11,7 +11,7 @@ cargo hack "${cmd}" --each-feature --optional-deps # Run with all features cargo "${cmd}" --all-features -if [[ "${RUST_VERSION}" == "nightly"* ]]; then +if [[ "$(rustc --version)" == *nightly* ]]; then # Check benchmarks cargo check --benches