From 8f7dfc81eedd407d93f7963c55d5406507d17742 Mon Sep 17 00:00:00 2001 From: James Yong Date: Sun, 25 Oct 2026 03:49:20 -0700 Subject: [PATCH] docs: link the upstream libtailscale conn-cleanup fix The Apple provenance record and upgrade log said the conn-cleanup fix was prepared for upstream. It is now tailscale/libtailscale#69, for tailscale/tailscale#21934. Truffle's patch is the same diff; drop it once the PR lands. Co-Authored-By: Claude Opus 5.5 --- apple/Vendor/README.md | 6 ++++-- docs/tailscale-upgrade.md | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/apple/Vendor/README.md b/apple/Vendor/README.md index 1ae7cb6..067b139 100644 --- a/apple/Vendor/README.md +++ b/apple/Vendor/README.md @@ -29,8 +29,10 @@ versions embedded in the resulting framework binaries. connections in a test). The Go-owned descriptor stays open until cleanup, so its number cannot be reused while the connection is alive. `newConn` returns the C descriptor so the added `TestConnCleanupAfterFDReuse` can drive it; the - test fails without the fix. The same change has been prepared for upstream; - drop this patch once upstream includes it. + test fails without the fix. The same change is proposed upstream in + [tailscale/libtailscale#69](https://github.com/tailscale/libtailscale/pull/69) + (issue [tailscale/tailscale#21934](https://github.com/tailscale/tailscale/issues/21934)); + drop this patch once it lands. Upstream's framed fd-passing records (`4e3b222`, `258321b9f`) replaced truffle's earlier remote-address patch: each connection's remote address diff --git a/docs/tailscale-upgrade.md b/docs/tailscale-upgrade.md index 6f7dcca..58f058c 100644 --- a/docs/tailscale-upgrade.md +++ b/docs/tailscale-upgrade.md @@ -9,7 +9,9 @@ typed-DERP-ID test patch is upstream. Upstream still keys connection cleanup by the C-side descriptor, whose number is reused almost immediately: in a test, 7 of 8 accepted connections never had their `net.Conn` closed. The new `libtailscale-conn-cleanup.patch` keys cleanup by the Go-owned descriptor and -adds a regression test that fails without it. The peer-notification and +adds a regression test that fails without it. The same change is proposed +upstream in [tailscale/libtailscale#69](https://github.com/tailscale/libtailscale/pull/69) +(issue [tailscale/tailscale#21934](https://github.com/tailscale/tailscale/issues/21934)). The peer-notification and IPN-stream-recovery patches are unchanged. See [the provenance record](../apple/Vendor/README.md).