Skip to content

Python REST API: Fail fast if code is either "UNAUTHORIZED" or "BAD_REQUEST" #783

Description

@showell

The Python REST API has aggressive retry logic if the underlying call to the server in call_on_each_event does not succeed. This retry logic can obscure obvious problems such as somebody having an out-of-date API key or somebody not supplying the correct type of narrow arguments.

There are more details here: https://chat.zulip.org/#narrow/stream/137-feedback/topic/api.20client.20silent.20failure

You will want to discuss the best approaches on Zulip before proceeding, but the basic idea is to look for "UNAUTHORIZED" or "BAD_REQUEST" in the code field that comes back from the server, and if you see those, you should immediately have the function either raise an Exception or somehow make it clear to the API author that they need to fix the problem.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions