feat(network-monitor): fund accounts from the funding service - #2603
Open
SantiagoPittella wants to merge 2 commits into
Open
feat(network-monitor): fund accounts from the funding service#2603SantiagoPittella wants to merge 2 commits into
SantiagoPittella wants to merge 2 commits into
Conversation
SantiagoPittella
added this pull request to stack #2602
September 9, 2026 19:25
SantiagoPittella
force-pushed
the
fs/3-network-and-monitor
branch
from
September 9, 2026 20:29
4b96675 to
ecd416b
Compare
SantiagoPittella
force-pushed
the
fs/3-network-and-monitor
branch
from
September 10, 2026 16:48
ecd416b to
6b76a4a
Compare
Mirko-von-Leipzig
approved these changes
Sep 11, 2026
Comment on lines
+196
to
+197
| /// The funding service client; `None` when none is configured (zero-fee chains only). | ||
| funding: Option<FundingClient>, |
Collaborator
There was a problem hiding this comment.
Not this PRs problem, but I wonder if we can't somehow make it so that these things are always required, even on zero-fee chains.
One option is of course to just not have zero fee chains.. but I was hoping the flows could remain agnostic to the fee amount, as in fee=N holds even for N=0.
SantiagoPittella
force-pushed
the
fs/3-network-and-monitor
branch
from
September 11, 2026 18:47
6b76a4a to
2a26ac9
Compare
SantiagoPittella
removed this pull request from stack #2602
September 11, 2026 21:01
SantiagoPittella
added this pull request to stack #2616
September 11, 2026 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support in hte network monitor for the funding service. The chain's faucet is no longer a source of fees, because a network does not always run a public faucet.
--faucet-urlstill configures the faucet checks.--funding-request-timeoutdefaults to two minutes, because the service answers only once its note is committed.Added operator documentation and internal page for design.
Changelog