Add allowlist database - #2608
Conversation
1a131f1 to
77e759c
Compare
| CREATE TABLE account_allowlist ( | ||
| id INTEGER PRIMARY KEY, | ||
| account_id BLOB UNIQUE, | ||
| invitation_digest BLOB UNIQUE, |
There was a problem hiding this comment.
should we make the invitation digest the PK?
There was a problem hiding this comment.
We can't because its optional :D
An admin is also allowed to inject an account ID directly without needing an invitation code.
There was a problem hiding this comment.
Would it be worth adding a notes column to this then? Something to write basic notes about who got the code, etc. Alternatively the invitation digest could be random and enforced and then we could get rid of id.
There was a problem hiding this comment.
Also should invitation_digest be indexed?
There was a problem hiding this comment.
I explicitly didn't want to track who got the code assigned here. I figured that could be done externally by whoever is handing them out. Otherwise we could also store the original code instead of the digest.
There was a problem hiding this comment.
Yeah, makes sense. IMO since this is supposed to be just for the closed mainnet and not a long term thing we could make it more immediately functional (eg if there is going to be a UI for editing the DB I think it could make sense to have notes there already, but the benefit is not substantial anyway so either way works for me; similarly for the actual invite code)
There was a problem hiding this comment.
That's fair; I was looking at it more from a perspective of who operates what i.e. sequencer operator is likely not the allowlist admin
Summary
Adds a new sequencer-only database for holding account allowlist data.
This is a separate database because:
Changelog
Stack created with GitHub Stacks CLI • Give Feedback 💬