feat(funding-service): collect deposits sent to the funding account - #2615
Open
SantiagoPittella wants to merge 3 commits into
Open
feat(funding-service): collect deposits sent to the funding account#2615SantiagoPittella wants to merge 3 commits into
SantiagoPittella wants to merge 3 commits into
Conversation
SantiagoPittella
added this pull request to stack #2616
September 11, 2026 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds funding for the funder account via a public pay-to-ID note holding the native asset, and the service finds and consumes it on its own.
Only public, pay-to-ID, targeting the funding account, holding nothing but the native asset are collected.
Deposits are consumed in their own transaction, so a note that turns out to be unconsumable cannot fail a request a client is waiting on.
--top-up-intervalcontrols how often it runs, defaulting to one minute.Changelog