Collect batch fees into the builder wallet - #2635
Closed
Mirko-von-Leipzig wants to merge 5 commits into
Closed
Mirko-von-Leipzig wants to merge 5 commits into
Mirko-von-Leipzig wants to merge 5 commits into
Conversation
Mirko-von-Leipzig
added this pull request to stack #2569
September 16, 2026 08:31
Mirko-von-Leipzig
force-pushed
the
mirko/batch-fees-collection
branch
from
September 16, 2026 13:07
8895a0c to
9107378
Compare
Mirko-von-Leipzig
marked this pull request as ready for review
September 16, 2026 13:54
Mirko-von-Leipzig
requested review from
PhilippGackstatter,
igamigo and
kkovaacs
September 16, 2026 13:55
Mirko-von-Leipzig
removed this pull request from stack #2569
September 17, 2026 11:59
Collaborator
Author
|
This will be a separate dApp service, not required yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spawns a separate task on the sequencer that periodically consumes p2id notes into the batch builder's wallet account.
Uses the database API to find unconsumed notes. For simplicity, each transaction is considered independent i.e. state is loaded fresh on each attempt, this avoids complex tracking of state.
This uses the expiration block height to guarantee that there is at most a single transaction in flight, and it waits pessimistically for this transaction to expire even if it has since been committed or dropped. This keeps things simple, and under the "good" flow has no downside since we are only attempted this every five or so minutes - long after this expiration has expired.
Part of #2501.
Changelog