fix(tx): gate only signature production outside the auth procedure - #3471
Merged
Conversation
zeapoz
reviewed
Aug 3, 2026
zeapoz
left a comment
zeapoz
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, left some comments!
Comment on lines
+58
to
+62
| /// Returns the compiled component code, so a transaction script can link against it and `call.` | ||
| /// the `emit_auth_request` procedure. | ||
| pub fn code() -> &'static AccountComponentCode { | ||
| &AUTH_REQUEST_PROBE_PACKAGE | ||
| } |
Collaborator
There was a problem hiding this comment.
Do we need this method? Can we not use e.g. AccountComponent::component_code as we're converting to that type in the tests anyway?
| execution_result, | ||
| Err(TransactionExecutorError::AuthRequestOutsideAuthProcedure) | ||
| ); | ||
| assert_matches!(execution_result, Ok(_)); |
Collaborator
There was a problem hiding this comment.
If we're only checking if the transaction succeeded then there should be no need for this assert_matches!, we could just unwrap directly.
PhilippGackstatter
approved these changes
Aug 3, 2026
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
Contributor
There was a problem hiding this comment.
LGTM with moving the auth probe component to miden-testing.
Collaborator
Author
|
@PhilippGackstatter Is it possible to merge this PR? It's a blocker for #3044 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3466