fix(protocol): verify input-note storage item count in the prologue - #3641
Merged
mmagician merged 9 commits intoAug 21, 2026
Merged
Conversation
mmagician
commented
Aug 20, 2026
Addresses review: promote the magic 0 in locaddr.0 to the PROCESS_NOTE_STORAGE_PREIMAGE_LOC constant. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Addresses review: "advised" is not used as an adjective in this codebase; refer to the item count from the advice map instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…_to_memory Addresses review: document the operand stack state right before the call to pipe_elements_preimage_to_memory. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Addresses review: "scratch buffer"/"scratch memory" is not used in this codebase; refer to memory locals / the preimage buffer instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mmagician
marked this pull request as ready for review
August 20, 2026 13:04
zeapoz
approved these changes
Aug 20, 2026
zeapoz
left a comment
zeapoz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, left a single nit about touching up the doc comments to leave out superfluous information
mmagician
commented
Aug 20, 2026
Co-authored-by: Marti <marcin.gorny.94@protonmail.com>
bobbinth
approved these changes
Aug 21, 2026
bobbinth
left a comment
bobbinth
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of optional comments inline..
Also, the original issue mentioned that we may be able to get some hashing somewhere else - but I'm not seeing any other changes. Did this not materialize?
mmagician
force-pushed
the
mmagician-claude/fix-l05-note-storage-count-verify
branch
from
August 21, 2026 08:07
4c24768 to
08356c0
Compare
Collaborator
Author
We could save on some extra hashing, but it does require a bit more refactoring. I've opened a draft PR #3659 to address this (I'm not yet fully convinced it's worth it though). Merging this PR as-is |
mmagician
deleted the
mmagician-claude/fix-l05-note-storage-count-verify
branch
August 21, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The transaction kernel prologue reads each input note's
num_storage_itemsfrom the advice provider, but never binds it to the note's authenticatedNOTE_STORAGE_COMMITMENT. This PR fixes itCloses #3593