feat(auth): add EIP-712 multisig signature verification - #3856
Open
VAIBHAVJINDAL3012 wants to merge 17 commits into
Open
feat(auth): add EIP-712 multisig signature verification#3856VAIBHAVJINDAL3012 wants to merge 17 commits into
VAIBHAVJINDAL3012 wants to merge 17 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds EIP-712 signature verification for ECDSA multisig approvers while preserving the existing raw-signature flow.
An ECDSA approver may provide either:
TX_SUMMARY_COMMITMENT; orMidenTransaction(bytes32 txSummaryHash).Falcon signatures continue using the existing raw path.
The implementation adds:
Two existing responsibilities intentionally remain separate:
AUTH_REQUEST_EVENT, while EIP-712 witnesses are supplied through a domain-separated advice-map entry. Reusing the event would require changing its existing stack contract and could break current hosts and authenticators.verify_signature_by_schemecontinues dispatching raw ECDSA and Falcon verification. EIP-712 uses a separate adapter because it is a message format—not a new signature scheme—and must first constructkeccak256(0x1901 || domainSeparator || structHash). It then delegates to the existing ECDSA verifier.Signed message
txSummaryHashis the transaction-summary commitment produced by the authentication component.Security properties
ecdsa_k256_keccakapprovers.Compatibility
The raw ECDSA and Falcon signature formats do not change.
Authentication procedure roots change for newly compiled multisig components. Existing deployed accounts retain their original account code.
Tests
Coverage includes:
Validated locally:
Scope
This first version signs only the transaction-summary commitment. Human-readable asset and transfer fields for Ledger clear signing are deferred to a follow-up.