feat(protobuf): improve ergonomics by combining decoding and verification - #3857
Merged
Merged
Conversation
zeapoz
approved these changes
Sep 14, 2026
zeapoz
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Left a tiny nit about the changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users of the
miden-protobuftypes have to do a repetitive dance of:This PR adds an extension trait
DecodeMessageExtwhich provides thedecode_and_verify(),decode_and_verify_with(), anddecode_and_build_unchecked()methods via blanket impls where appropriate.This is an ergonomic improvement.