Repository navigation
[Misc][PP] Log the KV cache memory of every worker and the SM70 indexer decode route of every stage - #1293
Open
Peuqui wants to merge 2 commits into
Open
[Misc][PP] Log the KV cache memory of every worker and the SM70 indexer decode route of every stage#1293Peuqui wants to merge 2 commits into
Peuqui wants to merge 2 commits into
Conversation
The pool is the minimum over the pipeline stages; rank 0 alone logs its figure, so the stage that limits it could not be told from the log. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011k7FsBAcZ8Cw91wisiZxMf Signed-off-by: Peuqui <43776522+Peuqui@users.noreply.github.com>
logger.info_once defaults to scope="local", which logs only on the first local rank, so on one node with pipeline parallelism only stage 0 named its decode route. In a DeepSeek-V4-Flash PP5 boot (three Tesla V100 and two Quadro RTX 8000) the prefill route lines, which already pass scope="process", came from all five stages and the decode route line from stage 0 alone. Both decode route lines now pass scope="process". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peuqui <43776522+Peuqui@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Two log lines that only the first pipeline stage printed, so a pipeline-parallel deployment could not be read from its log.
Not a duplicate: I searched the open PRs for "Available KV cache memory", "KV cache memory per worker", info_once, scope="process" and "indexer decode route", and compared the changed files with those of all open PRs. Our own #1276 changes vllm/v1/engine/core.py elsewhere, and our #1280, #1282 and #1286 change other parts of indexer.py (the prefill routes); a merge with each gives no conflict.
AI assistance was used for this change. I reviewed every line and ran the tests below.
Test Plan
Native build of this branch in place (TORCH_CUDA_ARCH_LIST=7.0), then one pytest process per file:
python -m pytest tests/kernels/test_deepseek_v4_sm70_indexer.py tests/v1/engine/test_engine_core.py
pre-commit run --from-ref origin/main --to-ref HEAD; pre-commit run mypy-3.10 --hook-stage manual --all-files
The log lines were read in a DeepSeek-V4-Flash PP5 boot of our fork (production entry, 2026-10-28).
Path coverage
Acceleration and benchmark contract (required for performance changes)
Test Result
On a Quadro RTX 8000 and on a Tesla V100: tests/kernels/test_deepseek_v4_sm70_indexer.py 26 passed. tests/v1/engine/test_engine_core.py: 10 failed, 1 skipped on both cards, the same test IDs on main 9a33cee with the same build (the tests load llava-hf/llava-1.5-7b-hf, whose weights are not on this machine, so EngineCore is not exercised here; the log line was read in the fork boot above).
pre-commit run --from-ref origin/main --to-ref HEAD: every hook passes except check-layering, which reports vllm/model_executor/layers/fused_moe/runner/moe_runner.py (platform coupling 37 -> 39), as on main 9a33cee; this PR does not touch that file. pre-commit run mypy-3.10 --hook-stage manual --all-files: the only errors are three arg-type errors in vllm/v1/attention/backends/flash_v100/runtime.py, which mypy reports on main as well in our environment and 1Cat's CI does not report; this PR does not touch that file.
🤖 Generated with Claude Code