bug: socket pong, ban-only teammate notices, tighter player delete, support notification text - #432
Merged
Merged
Conversation
This was referenced Sep 28, 2026
…upport notification text - reply to the web client's ping with a pong so a dead-but-OPEN socket is detectable - only a ban notifies former team-mates; mutes/gags/silences stay between the player and staff - only administrators can delete a player row - check-in error names team admins as well as the captain - name change requests link the player's profile (absolute url, Discord-routed) - match support notification names the requester, fixes the title typo, and requires the caller be in the lineup
lukepolo
force-pushed
the
bug/deafcs-sync-fixes
branch
from
September 28, 2026 21:44
95d14bd to
95853a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings over a batch of small fixes from DEAFCS: a socket pong, ban-only team-mate notices, admin-only player delete, and clearer support and name-change notifications.
/ws/webpinghandler now replies{ event: "pong" }straight away (anonymous sockets too), so a client can spot a dead connection. Web doesn't use it yet.public_playersdelete permission moves frommatch_organizertoadministrator.callForOrganizerfixes the "Assistanced" typo, names the requester (escaped, from their currentplayers.name) and refuses anyone not in the lineup.Merge/deploy:
yarn hasura:metadata(players delete permission).Tests: every fix above (pong, ban-only notices, delete permission, check-in message, name-change link, support-request name/typo/lineup check) has a unit test that fails without the fix. Based on DEAFCS 33d54cd, 04cf28a, 606d9bb, e5463f7