feature: sortable player role rank in search - #434
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a sortable integer
role_rankto the Typesense players collection, so the player directory can sort by privilege. Today it can only sort alphabetically by role name.roleRank(role)returns the role's position in the existingroleOrder(user0 …administrator6; unknown or null is 0).role_rank(int32, sortable), and every player upsert sets it.roleis unchanged.Merge/deploy: after deploy, run "Reindex Search" by hand (Settings → Application → Players) and wait for it to finish before merging web#613. The reindex queued at boot can be picked up by the old pod.
Tests: feature only, no bug fix. The schema, upsert and ordering tests fail when
role_rankis removed or ranked alphabetically. Based on DEAFCS 476dff9, c1d91b7