Skip to content

bug: import rush matches from valve - #437

Merged
lukepolo merged 1 commit into
mainfrom
bug/rush-imports
Sep 28, 2026
Merged

lukepolo merged 1 commit into
mainfrom
bug/rush-imports

Conversation

@lukepolo

@lukepolo lukepolo commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor
  • Rush imports were always rejected. Rush's seed pool has one map, so tai_match materializes rush_001 as soon as the import inserts the match. The importer's own map then trips check_match_map_count ("maximum number of picked maps"), and the import rolls back and ends up Failed. insertMatchMap now clears the trigger-made map first.
  • Rush detection is game_mode 6 or a rush_ map. Rush has no skill group, so rank_type can't identify it, and cs_rush is an unrelated hostage map.
  • Presence: rush counts as a matchmaking mode, so finishing a Rush match triggers the history poll.
  • persist_imported_demo skips Valve rank history and the premier_rank snapshot for Rush, because its scoreboard rank belongs to another ladder.
  • No metadata apply is needed; the SQL function is re-applied on boot. Rush imports that already failed can be retried from the external matches page.
  • Related: bug: rank type from the rank update, not the scoreboard demo-parser#9 (rank type from the rank update), bug: rush filter for imported valve matches web#609 (Rush filter).

@lukepolo
lukepolo merged commit 915f5f6 into main Sep 28, 2026
2 checks passed
@lukepolo
lukepolo deleted the bug/rush-imports branch September 28, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant