bug: import rush matches from valve - #437
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tai_matchmaterializes rush_001 as soon as the import inserts the match. The importer's own map then tripscheck_match_map_count("maximum number of picked maps"), and the import rolls back and ends up Failed.insertMatchMapnow clears the trigger-made map first.game_mode 6or arush_map. Rush has no skill group, so rank_type can't identify it, andcs_rushis an unrelated hostage map.rushcounts as a matchmaking mode, so finishing a Rush match triggers the history poll.persist_imported_demoskips Valve rank history and thepremier_ranksnapshot for Rush, because its scoreboard rank belongs to another ladder.