feature: relay in-game team chat into the team's web chat room - #448
Merged
Merged
Conversation
This was referenced Sep 28, 2026
lukepolo
force-pushed
the
feature/team-chat-relay
branch
from
September 29, 2026 00:59
301d1bc to
e14bb5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relays in-game
say_teaminto the speaker's private team chat room on the web; all chat still goes to the match room.teamChatgame event routes to theMatchTeamroom${matchId}:${lineupId}; an older api has no handler for it and drops itchatevent with team fields is dropped toorelay_team_chat: true(a JSON boolean), so the plugin only relays to an api that can route team chatMatchChatMessage(push follows thematch_chatpreference, off by default); a migration re-types existing rowsMerge/deploy: stacked on #435. Deploy the api before 5stackgg/game-server#196, and merge #451 before this goes live.
Tests: a test fails without each fix: stale team-room presence fan-out, team fields on
chat, a lineup from another match, a speaker not on the lineup, therelay_team_chatflag, and the migration's_escape. The malformed-speaker check only fails on "no Hasura query issued". Based on DEAFCS a986ab1ec