bug: bind game-server sockets to their own match and drop events after failed auth

src/matches/events/CaptainEvent.spec.ts

@@ -0,0 +1,65 @@
+import { Logger } from "@nestjs/common";
+import CaptainEvent from "./CaptainEvent";
+
+describe("CaptainEvent", () => {
+  let processor: CaptainEvent;
+  let hasura: { mutation: jest.Mock };
+  let matchAssistant: { getMatchLineups: jest.Mock };
+
+  beforeEach(() => {
+    hasura = { mutation: jest.fn(async () => ({})) };
+    matchAssistant = {
+      getMatchLineups: jest.fn(async () => ({
+        lineup_1_id: "lineup-1",
+        lineup_2_id: "lineup-2",
+        lineup_players: [
+          { steam_id: "76561198000000001", discord_id: null },
+          { steam_id: null, discord_id: "discord-2", placeholder_name: "bob" },
+        ] as Array<Record<string, string | null>>,
+      })),
+    };
+
+    processor = new CaptainEvent(
+      new Logger("CaptainEventTest"),
+      hasura as any,
+      matchAssistant as any,
+      {} as any,
+      {} as any,
+    );
+  });
+
+  function updateWhere() {
+    return hasura.mutation.mock.calls[0][0].update_match_lineup_players.__args
+      .where;
+  }
+
+  it("only changes the captain in this match's lineups", async () => {
+    processor.setData("11111111-1111-1111-1111-111111111111", {
+      claim: true,
+      steam_id: "76561198000000001",
+      player_name: "alice",
+    });
+
+    await processor.process();
+
+    expect(updateWhere()).toEqual({
+      steam_id: { _eq: "76561198000000001" },
+      match_lineup_id: { _in: ["lineup-1", "lineup-2"] },
+    });
+  });
+
+  it("scopes a placeholder player's claim to this match too", async () => {
+    processor.setData("11111111-1111-1111-1111-111111111111", {
+      claim: true,
+      steam_id: "0",
+      player_name: "bob",
+    });
+
+    await processor.process();
+
+    expect(updateWhere()).toEqual({
+      discord_id: { _eq: "discord-2" },
+      match_lineup_id: { _in: ["lineup-1", "lineup-2"] },
+    });
+  });
+});

src/matches/events/CaptainEvent.ts

@@ -35,6 +35,9 @@ export default class CaptainEvent extends MatchEventProcessor<{
             [lineup_player.steam_id ? "steam_id" : "discord_id"]: {
               _eq: lineup_player.steam_id || lineup_player.discord_id,
             },
+            match_lineup_id: {
+              _in: [match.lineup_1_id, match.lineup_2_id],
+            },
           },
           _set: {
             captain: this.data.claim,