bug: knife kills from other rounds don't count toward a best-round highlight - #463
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With "always include knife" on, auto highlights append knife kills from other rounds to the best-round reel, and those kills were added to its kill count (a 4K round + a later stab showed as 5K).
kills_count; the title still reads "Best Round (4K) + 1 Knife Kill"countKillsForSpecuses the spec'skills_countwhen present instead of recounting every kill in the footage, so the stored badge matches the burned-in chipMerge/deploy: api only, no migration; existing clips keep their old count until re-rendered.
Tests: new cases in
clips.service.spec.tsfail on main (5 vs 4) and pass here; unit suite green.Fixes 5stackgg/5stack-panel#636