bug: only send server and node status notifications that make sense - #468
Merged
Merged
Conversation
- no offline alerts for disabled servers, disabled/unused nodes, or servers whose node is already down (the node alert covers it) - intentional restarts/rebuilds get a 5 minute grace before any down alert - RCON-down alerts from the minute ping only fire after 2 minutes unreachable - online alerts only close a matching offline alert (node and region) - a node set to not accept new matches keeps that state across an outage
…ions-review # Conflicts: # src/dedicated-servers/dedicated-servers.service.spec.ts
- a server on a node that died is checked again once the node is back, so one that never returns is still reported - offline state is written right away; only the alert waits out a restart - Ranked RCON alerts respect the restart grace - unreachable streak restarts after a gap in pings, tolerates a missing entry, and only records an alert once it was sent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admins were getting offline/RCON alerts for servers they had just disabled or restarted, for nodes nobody uses, and duplicate or orphaned node/region alerts. This keeps only the alerts that point at a real, unexpected outage.
game_server_nodes.accepting_new_matchescolumn. Toggling a node that is down no longer marks it Online.