Skip to content

bug: season MVP requires 5 competitive matches #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukepolo merged 2 commits into from
Sep 30, 2026
Merged

bug: season MVP requires 5 competitive matches #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55fda6c
bug: season MVP only counts competitive matches
lukepolo Sep 30, 2026
53b75f7
bug: season MVP requires at least 5 competitive matches
lukepolo Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion hasura/functions/seasons/calculate_season_awards.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,11 @@ BEGIN
INTO _mvp_steam_id
FROM public.player_elo pe
WHERE pe.season_id = _season_id
-- Impact is relative to teammates, so a Duel scores a flat 1.08
-- regardless of result and would outrank every 5v5 regular.
AND pe."type" = 'Competitive'
GROUP BY pe.steam_id
HAVING COUNT(*) > 0
HAVING COUNT(*) >= 5
ORDER BY AVG(COALESCE(pe.impact, 1.0)) DESC,
SUM(COALESCE(pe.impact, 1.0)) DESC,
pe.steam_id ASC
Expand Down
113 changes: 100 additions & 13 deletions test/awards.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,20 +771,46 @@ describe("awards (SQL-driven)", () => {
describe("season awards", () => {
const seedSeasonElo = async (
seasonId: string,
rows: Array<{ steam: string; elo: number; impact: number }>,
rows: Array<{
steam: string;
elo: number;
impact: number;
type?: string;
matches?: number;
}>,
) => {
for (const row of rows) {
const { matchId } = await fx.bareMatch();
await postgres.query(
`INSERT INTO player_elo
(match_id, steam_id, season_id, type, current, change, impact,
expected_score, actual_score, k_factor)
VALUES ($1, $2, $3, 'Competitive', $4, 0, $5, 0.5, 1.0, 32)`,
[matchId, row.steam, seasonId, row.elo, row.impact],
);
for (let i = 0; i < (row.matches ?? 1); i++) {
const { matchId } = await fx.bareMatch();
await postgres.query(
`INSERT INTO player_elo
(match_id, steam_id, season_id, type, current, change, impact,
expected_score, actual_score, k_factor)
VALUES ($1, $2, $3, $6, $4, 0, $5, 0.5, 1.0, 32)`,
[
matchId,
row.steam,
seasonId,
row.elo,
row.impact,
row.type ?? "Competitive",
],
);
}
}
};

const seasonMvp = async (seasonId: string) => {
const [mvp] = await postgres.query<Array<{ player_steam_id: string }>>(
`SELECT ar.player_steam_id
FROM award_recipients ar
JOIN awards a ON a.id = ar.award_id
WHERE ar.season_id = $1 AND a.system_key = 'season_mvp'`,
[seasonId],
);
return mvp ? String(mvp.player_steam_id) : null;
};

it("ships the four season system awards", async () => {
const rows = await postgres.query<Array<{ system_key: string }>>(
`SELECT system_key FROM awards
Expand All @@ -810,7 +836,7 @@ describe("awards (SQL-driven)", () => {
{ steam: players[0], elo: 1400, impact: 1.0 },
{ steam: players[1], elo: 1300, impact: 1.0 },
{ steam: players[2], elo: 1200, impact: 1.0 },
{ steam: players[3], elo: 1100, impact: 1.9 },
{ steam: players[3], elo: 1100, impact: 1.9, matches: 5 },
]);

await postgres.query("SELECT calculate_season_awards($1)", [season.id]);
Expand Down Expand Up @@ -841,14 +867,65 @@ describe("awards (SQL-driven)", () => {
expect(String(rows[3].player_steam_id)).toBe(String(players[2]));
});

it("picks the mvp from competitive matches only", async () => {
const [season] = await postgres.query<Array<{ id: string }>>(
"INSERT INTO seasons (starts_at) VALUES (now()) RETURNING id",
);
const players = await fx.players(2);

await seedSeasonElo(season.id, [
{ steam: players[0], elo: 1200, impact: 1.05, matches: 5 },
{
steam: players[1],
elo: 1100,
impact: 1.08,
type: "Duel",
matches: 5,
},
{
steam: players[1],
elo: 1100,
impact: 1.2,
type: "Wingman",
matches: 5,
},
]);

await postgres.query("SELECT calculate_season_awards($1)", [season.id]);

expect(await seasonMvp(season.id)).toBe(String(players[0]));
});

it("requires five competitive matches for mvp", async () => {
const [season] = await postgres.query<Array<{ id: string }>>(
"INSERT INTO seasons (starts_at) VALUES (now()) RETURNING id",
);
const players = await fx.players(2);

await seedSeasonElo(season.id, [
{ steam: players[0], elo: 1200, impact: 1.2, matches: 4 },
{ steam: players[1], elo: 1100, impact: 1.01, matches: 4 },
]);

await postgres.query("SELECT calculate_season_awards($1)", [season.id]);
expect(await seasonMvp(season.id)).toBeNull();

await seedSeasonElo(season.id, [
{ steam: players[1], elo: 1100, impact: 1.01 },
]);

await postgres.query("SELECT calculate_season_awards($1)", [season.id]);
expect(await seasonMvp(season.id)).toBe(String(players[1]));
});

it("counts season medals on the awards leaderboard", async () => {
const [season] = await postgres.query<Array<{ id: string }>>(
"INSERT INTO seasons (starts_at) VALUES (now()) RETURNING id",
);
const players = await fx.players(3);

await seedSeasonElo(season.id, [
{ steam: players[0], elo: 1400, impact: 1.0 },
{ steam: players[0], elo: 1400, impact: 1.0, matches: 5 },
{ steam: players[1], elo: 1300, impact: 1.0 },
{ steam: players[2], elo: 1200, impact: 1.0 },
]);
Expand Down Expand Up @@ -910,7 +987,12 @@ describe("awards (SQL-driven)", () => {
const players = await fx.players(3);
await seedSeasonElo(
season.id,
players.map((steam, i) => ({ steam, elo: 1400 - i * 100, impact: 1 })),
players.map((steam, i) => ({
steam,
elo: 1400 - i * 100,
impact: 1,
matches: 5,
})),
);

const handId = await createAward("Season Community Pick");
Expand Down Expand Up @@ -943,7 +1025,12 @@ describe("awards (SQL-driven)", () => {
const players = await fx.players(3);
await seedSeasonElo(
season.id,
players.map((steam, i) => ({ steam, elo: 1400 - i * 100, impact: 1 })),
players.map((steam, i) => ({
steam,
elo: 1400 - i * 100,
impact: 1,
matches: 5,
})),
);

const calculated = async () =>
Expand Down
Loading