bug: check-in enforces the match's check-in setting - #490
Merged
Merged
Conversation
checkIntoMatch only checked the match status, so in Admin mode a player could still check in by calling the action directly (and enough of them pushed the match Live), and in Captains mode any lineup player could. It now evaluates can_check_in for the caller's own session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players could check in by calling the check-in action directly even when the match's check-in setting didn't allow it, and enough of those check-ins pushed the match Live.
checkIntoMatchrunscan_check_infor the caller's own session before anything elseFrom DEAFCS: DEAFCS/api-deafcs@047c9a60