bug: refresh the Play count after a matchmaking pass - #493
Merged
Merged
Conversation
Claiming lobbies for a ready check takes them out of the queue, but no matchmaking:region-stats went out, so every client kept showing them as queued. A pass that creates a confirmation now re-broadcasts once its unmatched claims are back in the queue; a failed broadcast is only logged.
A claim takes a lobby out of every region it queued in, so a broadcast made while another region's pass held one missed it, and a pass that put its claims back without a match never re-broadcast. Each pass that claimed anything now refreshes once, after its requeue, instead of once per confirmation path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When matchmaking found a match nothing re-broadcast the queue counts, so the Play count kept showing players who were already in a ready check or a match.
From DEAFCS: DEAFCS/api-deafcs@749aa67f