feature: banned teammates notification type and preference - #496
Merged
Merged
Conversation
Co-player ban notices move off PlayerSanctioned onto TeammateBanned, with their own push category (teammate_bans) and bell toggle, both on by default. Automatic Steam/VAC bans still notify. Players who had muted the account push category keep these muted.
The job runs once, so a co-player fan-out that threw (e.g. before Hasura knows TeammateBanned) silently lost the admin ban alert. Each notice is now isolated and logged, and the fan-out runs last.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bans now notify recent co-players under their own TeammateBanned type, so players can turn these off on Notification Preferences instead of a moderator ticking a box per ban.
TeammateBannedtype for the co-player notice; the banned player's own notice and the admin alert stayPlayerSanctionedteammate_banspush category afteraccount, plus aTeammateBannedbell toggle, both on by defaultaccountpushes keep these mutedFrom DEAFCS: DEAFCS/api-deafcs@ef78c9df