feature: bell switch for every notification type - #499
Merged
Merged
Conversation
Every per-player type gets an in-app key except a player's own account and safety notices (locked) and the push-only rings and chat. The push preference list now carries each category's types with how the bell treats them, so the web can list every kind without its own copy of the mapping. Organizer match alerts go through notifyPlayers so their new bell switch is honoured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives the bell a switch for every per-player notification type and tells the web which types each push category covers, so the new Notifications page can list every kind.
GET /notifications/preferences/pushreturns the types in each push categorynotifyPlayers, so their bell switch is honoured